Ds/custom editor #9960
Closed
Ds/custom editor #9960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Setup usage of the new API * Partial ideas * Idea for splitting * Idea in place * Get all of the tests to build * Enable proposed api * Still not working but setting more options. * Get web views to load * Fix save and save as to use VS code commands * Fix unit tests * Fix a number of functional tests * REmove autoSave tests as not needed anymore * Add news entry * Review comments * Code review comments * Update PR validation list * Fix nyc compiler problems. * Try fixing the toggle markdown test
…e-python into ds/custom_editor
* ids of new cells must be provided to actions * Comments * Oops
…e-python into ds/custom_editor
* Run tests against insiders * Disable noisy logging * Restore changes
For #9340 Ensures all actions have a base type, to pass information such whether the action was invoked to sync state for multiple editors (pointing to same file) in same session or across sessions. This PR only adds the ability to pass such new information to all actions.
For #9340 To be merged after #9840 Basically I got rid of the root level state info that keeps track of the cell that's selected and focused. This required us to keep the two in sync along with the state at the cell level. When syncing information between multiple editors this got messy. removing this removes the issues where things could go out of sync, i.e. two ways to storing the same thing. Now we get selected information from the cells directly - single source of truth.
For #9340 Note This PR adds the infrastructure necessary to sync edits & the like across editors for the same file Code has been commented out to ensure some remaining bits work properly Waiting on some of the new changes from @rchiodo from his undo PR. Remaining changes Ensuring we do not end up in a crazy loop that will cause one editor to propagate changes to the other, then that one back to this & so on Sync cell execution (currently creation of new cells isn't sync'ed across) Find a bullet proof solution for syncing focused states (this messes up everything - we don't need this in syncing editors, but if required for live share, then we need to ensure focus states work correctly - depending on whether liveshare even needs such a feature?) * Address code review comments * Fix test * Fix linter * Remove unused property * More changes
* We have code in extension that displays a dialog (preventing extension from loading) in insiders version of VSC. * Run tests against insiders * Restore env variable
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).