Skip to content

Conversation

DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Feb 6, 2020

For #9973
Currently conda isn't getting activated when auto starting Jupyter server.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Feb 6, 2020
@DonJayamanne DonJayamanne changed the title When auto-starting Jupyter activate conda env When starting Jupyter activate conda env Feb 6, 2020
@DonJayamanne
Copy link
Author

Does this CI even work...

@DonJayamanne DonJayamanne reopened this Feb 6, 2020
@codecov-io
Copy link

codecov-io commented Feb 7, 2020

Codecov Report

Merging #9972 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9972      +/-   ##
=========================================
- Coverage    61.2%   61.2%   -0.01%     
=========================================
  Files         564     564              
  Lines       30078   30083       +5     
  Branches     4550    4551       +1     
=========================================
+ Hits        18408   18411       +3     
- Misses      10640   10642       +2     
  Partials     1030    1030
Impacted Files Coverage Δ
src/client/common/terminal/helper.ts 94.52% <100%> (ø) ⬆️
src/client/interpreter/activation/service.ts 84.93% <0%> (-1.84%) ⬇️
src/client/interpreter/serviceRegistry.ts 100% <0%> (ø) ⬆️
src/client/common/utils/localize.ts 95.12% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb5cc9e...588a13f. Read the comment docs.

@DonJayamanne DonJayamanne reopened this Feb 7, 2020
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DonJayamanne DonJayamanne merged commit 9274435 into microsoft:master Feb 7, 2020
@DonJayamanne DonJayamanne deleted the condaEnvNotGettingActivated branch February 7, 2020 01:26
DonJayamanne added a commit that referenced this pull request Feb 7, 2020
* If interpreter is provided use that to check if is conda environment
* Fix tests
For #9973
Currently conda isn't getting activated when auto starting Jupyter server.
@lock lock bot locked as resolved and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants