Skip to content

Porting K8 fix to release #9987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Porting K8 fix to release #9987

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfae94e
add the ip argument of jupyter server for k8s container (#9977)
tom-shan Feb 7, 2020
36958f7
update changelog
IanMatthewHuff Feb 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
([#9701](https://github.com/Microsoft/vscode-python/issues/9701))

### Fixes
1. add --ip=127.0.0.1 argument of jupyter server when running in k8s container
([#9976](https://github.com/Microsoft/vscode-python/issues/9976))
1. Correct the server and kernel text for when not connected to a server.
([#9933](https://github.com/Microsoft/vscode-python/issues/9933))
1. Make sure to clear variable list on restart kernel.
Expand Down
2 changes: 1 addition & 1 deletion src/client/datascience/jupyter/notebookStarter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ export class NotebookStarter implements Disposable {
// Check for a docker situation.
try {
const cgroup = await this.fileSystem.readFile('/proc/self/cgroup').catch(() => '');
if (!cgroup.includes('docker')) {
if (!cgroup.includes('docker') && !cgroup.includes('kubepods')) {
return args;
}
// We definitely need an ip address.
Expand Down