Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate demo app to .NET 6 #31

Merged
merged 4 commits into from
Oct 28, 2022
Merged

Migrate demo app to .NET 6 #31

merged 4 commits into from
Oct 28, 2022

Conversation

cmaneu
Copy link
Member

@cmaneu cmaneu commented Oct 10, 2022

Fixes #30

@cmaneu cmaneu marked this pull request as ready for review October 10, 2022 19:27
@cmaneu cmaneu mentioned this pull request Oct 10, 2022
Closed
bamurtaugh
bamurtaugh reviewed Oct 10, 2022
View reviewed changes
Copy link
Member

@bamurtaugh bamurtaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening!

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Show resolved Hide resolved
.devcontainer/devcontainer.json Show resolved Hide resolved
.vscode/launch.json Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Show resolved Hide resolved
SECURITY.md Show resolved Hide resolved
@cmaneu
Resolve bamurtaugh comments
205bae0 
- Update documentation to point to the new devcontainer org
- Add settings and ports mappings to devcontainer
- Remove .NET "core" mention
@cmaneu
Copy link
Member Author

cmaneu commented Oct 11, 2022

Hey @bamurtaugh,
Thanks for all your comments.

  • I've resolved some of them,
  • For Contributing.md and Security.md, my recommendation is to keep them, and add them on all other repos (we can help)
  • And I have a specific question on this Migrate demo app to .NET 6 #31 (comment)

@bamurtaugh
Copy link
Member

Thanks for the great collab here, @cmaneu!

Followed up on the outstanding comments, and I think once we address them, we can merge this PR and rename this repo 😄

@cmaneu
Copy link
Member Author

cmaneu commented Oct 24, 2022 •
edited
Loading

Hi @bamurtaugh,
I've fixed all remaining comments on that PR. I've also asked my colleagues to take care of SECURITY.md and CODE_OF_CONDUCT.md on other repos. All of them are ready now:

@cmaneu cmaneu mentioned this pull request Oct 24, 2022
Closed
@codemillmatt
Copy link

@codemillmatt as FYI.

@bamurtaugh
Copy link
Member

Thanks so much @cmaneu and team! Going to now merge this PR, rename the repo, and merge the PRs in the other repos 🚀.

@bamurtaugh bamurtaugh merged commit 4a3b481 into microsoft:main Oct 28, 2022
@cmaneu cmaneu mentioned this pull request Nov 29, 2022
Closed
@vscodenpa vscodenpa added this to the May 2024 milestone May 21, 2024
@microsoft microsoft locked as resolved and limited conversation to collaborators May 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bamurtaugh bamurtaugh bamurtaugh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
May 2024
Development

Successfully merging this pull request may close these issues.

Updating this repo to .NET 6
4 participants
@cmaneu @bamurtaugh @codemillmatt @vscodenpa