Clamp VSCode download to stable release until NLS issue on Insiders is fixed #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that if the bug is not fixed either in this repo, or the main VSCode, it'll start breaking again when NLS changes from Given that |
|
microsoft/vscode#220171 got fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently launching VSCode leads to partial crash and unusuable state (mount issues and NLS-related logs in DevTools console).
Root cause indicated by VSCode team suggest latest changes in NLS might have affected it.
Switching from "insider" to "stable" version download fixes the problem.
This PR clamps the version to "stable" and unblocks vscode-test-web functionality again.
The intention is to figure out the necessary change either in vscode-test-web codebase, or in the VSCode itself, while the core functionality is back to working.
See microsoft/vscode#220171 for details of the issue.