Fix stream bugs #196
Merged
Fix stream bugs #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old interface definition was incorrect; this led to `Stream.read` being called with a number as its `mode` parameter, which was interpreted as the read having no maximum length.
* The initial loop failed to increment `resultSize`, making it a nop. `resultSize` would always be the initial chunk's size. * The main loop shifted chunks before checking for their inclusion in the output, causing the first excluded chunk to be silently dropped. * Chunks were shifted in a loop which iterated based on index/length, meaning we always ignored half of the available chunks.
|
@microsoft-github-policy-service agree |
|
Can confirm this PR fixes all the problems still present from #178 |
dbaeumer
approved these changes
Sep 10, 2024
chrmarti
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve the remaining bugs underlying #178.