Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot format multiple selections #103745

Closed
aicest opened this issue Aug 1, 2020 · 1 comment
Closed

Cannot format multiple selections #103745

aicest opened this issue Aug 1, 2020 · 1 comment
Assignees
@jrieken
Labels
feature-request Request for new features or functionality formatting Source formatter issues insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2020

Comments

@aicest
Copy link
Member

aicest commented Aug 1, 2020 •
edited
Loading

  • VSCode Version: 1.47.3
  • OS Version: Windows_NT x64 10.0.18363

Steps to Reproduce:

  1. use ctrl+d select multiple
  2. run format selection to format them

Demo: https://webmshare.com/play/eadOq

Does this issue occur when all extensions are disabled?: Yes
@aicest aicest mentioned this issue Aug 1, 2020
Closed
@jrieken jrieken added this to the August 2020 milestone Aug 10, 2020
@jrieken jrieken added feature-request Request for new features or functionality formatting Source formatter issues labels Aug 10, 2020
jrieken added a commit that referenced this issue Aug 19, 2020
@jrieken
support array of ranges in formatDocumentRangesWithProvider and forma…
379bfe6 
…tDocumentRangesWithSelectedProvider, #103745
@jrieken jrieken added the verification-needed Verification of issue is requested label Aug 31, 2020
@jrieken
Copy link
Member

jrieken commented Aug 31, 2020

To verify:

  • use TypeScript or another language for which you have selection formatting support
  • select multiple code snippets and run "Format Selection"
  • make sure all selections are formatted in a single operation, e.g a single undo operation is enough to undo the formatting changes
  • make sure empty selections are expanded to the whole line
  • make sure selections on the same line works as well as selections on different lines

@mjbvz mjbvz added the verified Verification succeeded label Sep 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality formatting Source formatter issues insiders-released Patch has been released in VS Code Insiders verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2020
Development

Successfully merging a pull request may close this issue.

Format multiple selections
4 participants
@jrieken @aicest @mjbvz and others