Side by side notebooks and error highlights

[jrieken]

It seems like reliable steps are:

1. Have notebook1 with problems open in the left hand side and nodebook2 open on the right
2. Put your focus in notebook2
3. Click on the problems view
4. notebook1 will open on the right hand side, but the line/code cell will not be highlighted 🐛

Originally posted by @connor4312 in #104454 (comment)

[jrieken]

Those steps don't reproduce this for me. @connor4312 please check again or refine steps

[connor4312]

Here's a video of what I'm seeing: https://memes.peet.io/img/20-09-c7c7e81b-d4a4-4696-b1c7-cf707dd7e283.mp4

It seems like the first open actually does focus the cell, but not the line. This is particularly noticable if you have a long code cell where the problem might not even be in view on the first click.

[jrieken]

This works better not not really good.

[jrieken]

@rebornix I am now using revealLineInCenterIfOutsideViewportAsync which seems very promising and it does fix the original bug but when having a simpler case it doesn't work. Do this

1. have a large code cell (see below)
2. make sure the error isn't visible
3. select the error in the errors pane
4. 🐛 the line isn't scrolled into view

$rpo=repo:microsoft/vscode


































$repo is:open milestone:"April 2020" assignee:@me label:*english-please

[rebornix]

Verifier: please test #106215 (comment) .