Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated terminal very slow #108590

Closed
clayms opened this issue Oct 13, 2020 · 23 comments
Closed

Integrated terminal very slow #108590

clayms opened this issue Oct 13, 2020 · 23 comments
Assignees
Labels
info-needed Issue requires more information from poster terminal Integrated terminal issues

Comments

@clayms
Copy link

clayms commented Oct 13, 2020

Issue Type: Bug

Just after the most recent update, the Integrated terminal is extremely slow to display any text, either entering commands or displaying the stdout of commands.
Many times typing a complete command at the prompt will show up a s-i-n-g-l-e - c-h-a-r-a-c-t-e-r - a-t - a - t-i-m-e over several seconds after you finished typing.

It does not matter which Shell I use (PowerShell, CMD, WSL bash, Git Bash). Although, the bash shells seem to perform a little better.

All of these Shells perform normally on my computer, it is only when running in the Intergrated Terminal in VSCode.

Also, connecting to a remote computer with ssh, the stdout is also very slow. Again, no problems using in any Shell outside of VSCode.

Is there some setting and can change back?

VS Code version: Code 1.50.0 (93c2f0f, 2020-10-07T06:10:52.432Z)
OS version: Windows_NT x64 10.0.18363

System Info
Item Value
CPUs Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 15.88GB (8.05GB free)
Process Argv --crash-reporter-id f652528b-5678-4b12-9ca0-3de6b1e1135f
Screen Reader no
VM 0%
Extensions (7)
Extension Author (truncated) Version
better-toml bun 0.3.2
macros ged 1.2.1
graphviz-markdown-preview gee 0.0.8
sftp lix 1.12.9
marp-vscode mar 0.15.1
python ms- 2020.9.114305
rust rus 0.7.8
@clayms
Copy link
Author

clayms commented Oct 13, 2020

changing the following settings helped. Not sure why an update would make the Integrated Terminal nearly unusable.

    "terminal.integrated.allowChords": false,
    "terminal.integrated.drawBoldTextInBrightColors": false,
    "terminal.integrated.experimentalLinkProvider": false,
    "terminal.integrated.rendererType": "auto"

@dr-gino
Copy link

dr-gino commented Oct 17, 2020

Using the Docker extension to view logs (around a 8000 lines) of a container would make not just the terminal but the entire VSCode editor laggy.
Setting "terminal.integrated.rendererType" from "dom" to "auto" did the trick. I had never touched that setting before.

Version: 1.50.1 (system setup)
Commit: d2e414d
Date: 2020-10-13T15:06:15.712Z (3 days ago)
Electron: 9.2.1
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.18362

@Tyriar
Copy link
Member

Tyriar commented Oct 30, 2020

@clayms could you try out "terminal.integrated.rendererType": "experimentalWebgl"? If you could capture a performance profile through the devtools performance tab (help > toggle dev tools) and upload it that would let us know if the main thread is being blocked and by what.

@Tyriar Tyriar added terminal Integrated terminal issues info-needed Issue requires more information from poster labels Oct 30, 2020
@testworksau
Copy link

Hi @meganrogge, @Tyriar 👋

Is this issue closed because it is fixed? Or do you still need more info?

FWIW I have the same issue, which is only present when terminal.integrated.rendererType is set to dom. I don't believe I have changed that setting before.

Here's the performance profile from my machine.

Version: 1.51.0 (user setup)
Commit: fcac248b077b55bae4ba5bab613fd6e9156c2f0c
Date: 2020-11-05T18:18:23.642Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19041

Profile-20201111T132351.zip

@Tyriar
Copy link
Member

Tyriar commented Nov 11, 2020

@testworksau the profile's interesting, not sure what could cause this apart from a Chromium issue (cc @deepak1556):

image

It looks different to the OP's issue, typically slow rendering like this in the terminal on Windows is due to this issue #76548

@jamilraichouni
Copy link

jamilraichouni commented Nov 26, 2020

changing the following settings helped. Not sure why an update would make the Integrated Terminal nearly unusable.

    "terminal.integrated.allowChords": false,
    "terminal.integrated.drawBoldTextInBrightColors": false,
    "terminal.integrated.experimentalLinkProvider": false,
    "terminal.integrated.rendererType": "auto"

That solved the same issue I had.
Thanks!

Update:

My issue seems to be sth. else. Keyboard lags regularly but only when using the bluetooth keyboard.
That happens in VS Code terminal but also when using other apps since I'm on macOS Big Sur.
Nearly identical hardware with same OS and mainly same apps (except Teams/ OneDrive and more from my employer)
does not have that problem. Hence, this is somewhat related to the mix of apps/ setup on my machine.

@johngrant
Copy link

johngrant commented Dec 4, 2020

I'm having this issue also. Let me know if I can add diagnostic data to this issue or another.

Version: 1.51.1
Commit: e5a624b
Date: 2020-11-11T01:11:34.018Z
Electron: 9.3.3
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 20.1.0

image

@Fortidude
Copy link

Terminal still very slow and it likes to freeze for 1-2 seconds when just typing.

@thecaffeinedev
Copy link

I am also facing the same issue. Integrated terminal freezes for 1-2 seconds while typing.

@deepak1556
Copy link
Collaborator

@Fortidude @thecaffeinedev what is your operating system and version ?

@thecaffeinedev
Copy link

@deepak1556 I am using Mac OS Big Sur. Vs code version is: 1.51.1

@deepak1556
Copy link
Collaborator

deepak1556 commented Dec 6, 2020

Thanks, please subscribe to #105446 for slowdown issues with terminal on Big sur.

@gabrielpaivadev
Copy link

Terminal still very slow and it likes to freeze for 1-2 seconds when just typing.

Same here.

Windows 10

@mkotsollaris
Copy link

For my setup (macos + big sur), this command fixed the problem:

🔺 codesign --remove-signature /Applications/Visual\ Studio\ Code.app/Contents/Frameworks/Code\ Helper\ \(Renderer\).app

In case you don't have xcrun, you can install it via:

xcode-select --install

and then make sure to run the 🔺 command!

@thecaffeinedev
Copy link

I also fixed mine by using the same commands as your @mkotsollaris . Not sure about windows though.

@testworksau
Copy link

@deepak1556 do you have any commentary on this? Do you need me to raise a new bug?

#108590 (comment)

@deepak1556
Copy link
Collaborator

@testworksau does running with --disable-renderer-accessibility fix the issue ?

@testworksau
Copy link

@testworksau does running with --disable-renderer-accessibility fix the issue ?

@deepak1556 setting terminal.integrated.rendererType to anything other than dom fixed the issue for me.

Do you want me to try --disable-renderer-accessibility with terminal.integrated.rendererType set to dom?

@deepak1556
Copy link
Collaborator

yes please try the flag with dom renderer for the terminal. Also can you take a performance profile in this setup ?

@pfisterer
Copy link

@deepak1556 For me, this notably improves terminal response time on Big Sur.

@MacKentoch
Copy link

So what is this issue from?

A lot of possible fixes but this is messy.

@pietroastolfi
Copy link

--disable-renderer-accessibility

This worked for me as well. But still this is just a trick to avoid the problem, not a real solution.

@coolsoftwaretyler
Copy link

Hey folks, I'm experiencing an issue I believe to be the same thing.

Here's my VS code info:

Version: 1.52.1
Commit: ea3859d4ba2f3e577a159bc91e3074c5d85c0523
Date: 2020-12-16T16:30:02.420Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Darwin x64 20.2.0

And my machine info:

Screen Shot 2020-12-23 at 6 59 01 PM

thanks for all your work!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests