Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter hints persists when changing view to Settings #115265

Closed
tanhakabir opened this issue Jan 27, 2021 · 5 comments
Closed

Parameter hints persists when changing view to Settings #115265

tanhakabir opened this issue Jan 27, 2021 · 5 comments
Assignees
@jrieken @mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug editor-parameter-hints Function, method and class parameter hint widget ux User experience issues verified Verification succeeded
Milestone
March 2021

Comments

@tanhakabir
Copy link
Contributor

  • VSCode Version: 1.53.0-insiders
  • OS Version: Win 10 1909

Steps to Reproduce:

  1. Create a new Notebook using the command palette command: Jupyter: Create New Blank Notebook
  2. Create some dummy code where some sort of info dialog pops up
  3. While dialog is open click on Settings gear and see that dialog is still open

recording (7)

Does this issue occur when all extensions are disabled?: N/A
@tanhakabir tanhakabir added the ux User experience issues label Jan 27, 2021
@jrieken
Copy link
Member

jrieken commented Jan 28, 2021

I cannot reproduce. @tanhakabir is the the new native notebooks or pythons custom notebooks?

@tanhakabir
Copy link
Contributor Author

@jrieken using the Jupyter notebook on insiders which I believe uses the native notebooks?

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Mar 2, 2021
@jrieken jrieken changed the title Suggestion dialog persists when changing view to Settings Parameter hints persists when changing view to Settings Mar 2, 2021
@jrieken jrieken assigned mjbvz and unassigned rebornix Mar 2, 2021
@jrieken
Copy link
Member

jrieken commented Mar 2, 2021

This is signature help and reproduces also outside of notebooks

  • open a TS file
  • trigger signature help
  • focus the SCM view
  • 😕 signature help still shows

jrieken added a commit that referenced this issue Mar 2, 2021
@jrieken
cancel parameter hints when editor blurs, #115265
85cbc2b
@jrieken jrieken added editor-parameter-hints Function, method and class parameter hint widget and removed notebook labels Mar 2, 2021
@jrieken jrieken added this to the March 2021 milestone Mar 2, 2021
@jrieken
Copy link
Member

jrieken commented Mar 2, 2021

@mjbvz I have pushed a change that cancels parameter hints when the editor blurs

@jrieken jrieken closed this as completed Mar 2, 2021
@lramos15 lramos15 added the verified Verification succeeded label Mar 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug editor-parameter-hints Function, method and class parameter hint widget ux User experience issues verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

No branches or pull requests
6 participants
@rebornix @jrieken @lramos15 @tanhakabir @mjbvz and others