Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP (built-in): Incorrect syntax highlighting for interface extends #116103

Closed
Kroc opened this issue Feb 8, 2021 · 4 comments · Fixed by atom/language-php#456 or #150067
Closed

PHP (built-in): Incorrect syntax highlighting for interface extends #116103

Kroc opened this issue Feb 8, 2021 · 4 comments · Fixed by atom/language-php#456 or #150067
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders php PHP support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
May 2022

Comments

@Kroc
Copy link

Kroc commented Feb 8, 2021

Related to #113185

PHP allows for Interfaces to be extended. The interface name provided is not recognised / coloured correctly.

image
@vscodebot
Copy link

vscodebot bot commented Feb 8, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@aeschli aeschli assigned roblourens and unassigned aeschli Feb 9, 2021
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug php PHP support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Feb 9, 2021
@roblourens roblourens added this to the February 2021 milestone Feb 9, 2021
@roblourens roblourens mentioned this issue Feb 9, 2021
Closed
@roblourens
Copy link
Member

Filed atom/language-php#414

@roblourens roblourens modified the milestones: February 2021, March 2021 Feb 24, 2021
@roblourens roblourens modified the milestones: March 2021, Backlog Mar 24, 2021
@KapitanOczywisty KapitanOczywisty mentioned this issue May 1, 2022
Merged
@KapitanOczywisty
Copy link
Contributor

@roblourens Merged upstream :)

@roblourens roblourens modified the milestones: Backlog, May 2022 May 20, 2022
@roblourens
Copy link
Member

Thanks!

@roblourens roblourens mentioned this issue May 21, 2022
Merged
roblourens added a commit that referenced this issue May 21, 2022
@roblourens
Bump php grammar, fix #142824, fix #116103
409e072
roblourens added a commit that referenced this issue May 21, 2022
@roblourens
Bump php grammar, fix #142824, fix #116103 (#150067)
3649387
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 21, 2022
@TylerLeonhardt TylerLeonhardt added the verified Verification succeeded label Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders php PHP support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
May 2022
6 participants
@Kroc @roblourens @TylerLeonhardt @aeschli @KapitanOczywisty @vscodenpa