Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php 8.1.1 enum types has wrong syntax highlighting #142824

Closed
Temepest74 opened this issue Feb 11, 2022 · 4 comments · Fixed by atom/language-php#456 or #150067
Closed

php 8.1.1 enum types has wrong syntax highlighting #142824

Temepest74 opened this issue Feb 11, 2022 · 4 comments · Fixed by atom/language-php#456 or #150067
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders php PHP support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@Temepest74
Copy link

Issue Type: Bug

  1. create new php fiel
  2. add a new enum into it, somethig like this
<?php
enum Status : string
{
    case VALID = 'VALID';
    case NOT_FOUND = 'NOT_FOUND';
}

VS Code version: Code 1.64.2 (f80445a, 2022-02-09T22:02:28.252Z)
OS version: Windows_NT x64 10.0.22000
Restricted Mode: No
Remote OS version: Linux x64 5.10.60.1-microsoft-standard-WSL2
Remote OS version: Linux x64 5.10.60.1-microsoft-standard-WSL2

System Info
Item Value
CPUs Intel(R) Core(TM) i7-9700F CPU @ 3.00GHz (8 x 3000)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: enabled_on
video_decode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.94GB (16.40GB free)
Process Argv --folder-uri=vscode-remote://wsl+Ubuntu/home/cata/client --remote=wsl+Ubuntu --crash-reporter-id 71692702-3f77-4482-9a75-b5ffd6c91b20
Screen Reader no
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 5.10.60.1-microsoft-standard-WSL2
CPUs Intel(R) Core(TM) i7-9700F CPU @ 3.00GHz (8 x 2999)
Memory (System) 19.55GB (13.08GB free)
VM 0%
Item Value
Remote WSL: Ubuntu
OS Linux x64 5.10.60.1-microsoft-standard-WSL2
CPUs Intel(R) Core(TM) i7-9700F CPU @ 3.00GHz (8 x 2999)
Memory (System) 19.55GB (13.08GB free)
VM 0%
Extensions (68)
Extension Author (truncated) Version
better-comments aar 2.1.0
laravel-blade cjh 1.1.2
apacheconf-snippets eim 1.3.0
auto-rename-tag for 0.1.10
openssl-configuration-file gee 0.0.1
monkey-patch ioc 0.1.16
vscode-peacock joh 4.0.0
dotenv mik 1.0.1
jupyter-keymap ms- 1.0.0
remote-containers ms- 0.217.2
remote-ssh ms- 0.70.0
remote-ssh-edit ms- 0.70.0
remote-wsl ms- 0.64.2
vscode-remote-extensionpack ms- 0.21.0
php-docblocker nei 2.6.1
vscode-icons vsc 11.9.0
JavaScriptSnippets xab 1.8.0
rainbow-brackets 2gu 0.0.6
vscode-css-formatter aes 1.0.2
laravel-extra-intellisense ami 0.6.1
beautify-blade api 1.0.1
laravel-blade-spacer aus 2.1.3
vscode-intelephense-client bme 1.8.0
vscode-tailwindcss bra 0.7.6
turbo-console-log Cha 2.1.7
path-intellisense chr 2.7.0
laravel-goto-view cod 1.3.7
gitlens eam 11.7.0
vscode-html-css ecm 1.11.0
EditorConfig Edi 0.16.4
vscode-npm-script eg2 0.3.24
apacheconf-snippets eim 1.3.0
prettier-vscode esb 9.2.0
shell-format fox 7.2.2
vscode-pull-request-github Git 0.36.1
svg joc 1.4.17
dockerfile-validator mar 1.2.0
php-namespace-resolver Meh 1.1.8
git-graph mhu 1.30.0
dotenv mik 1.0.1
file-downloader min 1.0.11
vscode-docker ms- 1.19.0
python ms- 2022.0.1814523869
vscode-pylance ms- 2022.2.1
jupyter ms- 2022.1.1001821375
jupyter-keymap ms- 1.0.0
jupyter-renderers ms- 1.0.6
sqltools mtx 0.23.0
sqltools-driver-mysql mtx 0.2.0
sqltools-driver-sqlite mtx 0.2.0
reload nat 0.0.6
php-docblocker nei 2.6.1
laravel-extension-pack one 1.0.0
vscode-php-getters-setters php 1.2.3
composer-links pix 0.0.1
vscode-css-peek pra 4.2.0
vscode-xml red 0.18.3
vscode-yaml red 1.4.0
laravel-artisan rya 0.0.28
vscode-blade-formatter shu 0.12.3
laravel-goto-controller ste 0.0.15
code-spell-checker str 2.1.6
code-spell-checker-medical-terms str 1.0.14
pdf tom 1.2.0
vscode-import-cost wix 2.15.0
php-debug xde 1.23.0
markdown-all-in-one yzh 3.4.0
html-css-class-completion Zig 1.20.0
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392cf:30425750
pythontb:30283811
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
pythonvspyt200:30340761
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
vsc1dsc:30433058
pythonvs932:30410667
wslgetstarted:30433507
vsrem710:30416614
pythonvspyt640:30436486
vsbas813:30436447
vscscmwlcmc:30433760

@Temepest74
Copy link
Author

This is how the enum looks inside my IDE.
image
I am certain that it should look different. With some colors at least for the enum and the name of the enum.

@roblourens
Copy link
Member

Filed this upstream: atom/language-php#451

@KapitanOczywisty
Copy link
Contributor

@roblourens Merged upstream :)

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) php PHP support issues labels May 20, 2022
@roblourens
Copy link
Member

Thank you!

@roblourens roblourens added this to the May 2022 milestone May 20, 2022
roblourens added a commit that referenced this issue May 21, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 21, 2022
@lramos15 lramos15 added the verified Verification succeeded label Jun 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders php PHP support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
5 participants