Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native title bar on GNOME (Linux) does not adapt to light/dark theme switches #130974

Closed
cbrnr opened this issue Aug 17, 2021 · 9 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron linux Issues with VS Code on Linux titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded

Comments

@cbrnr
Copy link

cbrnr commented Aug 17, 2021

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.59.0
  • OS Version: Linux (GNOME 40.3 X11)

Steps to Reproduce:

  1. Open VS Code
  2. Switch GNOME theme from light to dark (or vice versa)
  3. VS Code adapts to the new theme, but the title bar stays how it initially was. Sometimes, it changes to dark on the first light->dark switch, but then it never switches back to light (logging out of the session solves this).
    Peek 2021-08-17 10-16
@reuseman
Copy link

reuseman commented Jul 3, 2022

It's still happening the same thing with the 1.68.1 version. By setting "window.titleBarStyle": "custom" it shows the Windows UI

@deepak1556
Copy link
Collaborator

This is an issue with the native titlebar which is rendered by the runtime and not VSCode, please check if the issue persists with latest stable 1.73.

@deepak1556 deepak1556 added the info-needed Issue requires more information from poster label Dec 7, 2022
@cbrnr
Copy link
Author

cbrnr commented Dec 7, 2022

Yes, the issue still persists with 1.73.1.

@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron confirmation-pending linux Issues with VS Code on Linux and removed info-needed Issue requires more information from poster labels Dec 7, 2022
@cbrnr
Copy link
Author

cbrnr commented Dec 7, 2022

With the latest GNOME and specifically the use of GTK4, most apps do not adapt to the desktop theme (anymore). Even some GNOME apps themselves, for example Terminal, ignore the desktop theme (but the newer Console works). I think GTK4 probably changed how it notifies when the desktop theme changes.

@deepak1556 deepak1556 added confirmed Issue has been confirmed by VS Code Team member titlebar VS Code main title bar issues upstream-issue-pending Issues that are caused by chromium but have not been reported due to pending minimal repro and removed confirmation-pending labels Dec 9, 2022
@jnns
Copy link

jnns commented Aug 15, 2023

The Open-File / Save-File-As dialogs don't adapt to the current colorscheme either. Not sure if this is related or breaking the scope of this ticket.

@deepak1556
Copy link
Collaborator

Upstream PR electron/electron#38977

@deepak1556 deepak1556 added upstream-issue-linked This is an upstream issue that has been reported upstream and removed upstream-issue-pending Issues that are caused by chromium but have not been reported due to pending minimal repro labels Aug 16, 2023
@slagiewka
Copy link

Upstream PR electron/electron#38977

The aforementioned PR has been merged and released as v25.8.4.

@slagiewka
Copy link

Electron bumped by #194487 and #194488.

I've installed Code Insiders 1.83 and toggling dark and light themes in KDE works. Tested with native and custom title bar. Tested with "Auto Detect Color Scheme" ON.

@deepak1556
Copy link
Collaborator

/fixedWith 318f421

@deepak1556 deepak1556 added the verified Verification succeeded label Oct 2, 2023
@deepak1556 deepak1556 added this to the September 2023 milestone Oct 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug confirmed Issue has been confirmed by VS Code Team member electron Issues and items related to Electron linux Issues with VS Code on Linux titlebar VS Code main title bar issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants