Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inlay hints jump a lot when declaring a local #133730

Closed
alexdima opened this issue Sep 24, 2021 · 4 comments
Closed

Inlay hints jump a lot when declaring a local #133730

alexdima opened this issue Sep 24, 2021 · 4 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug inlay-hints verification-needed Verification of issue is requested verified Verification succeeded
Milestone
January 2022

Comments

@alexdima
Copy link
Member

TO_UPLOAD

I think the inlay hint is always correct, i.e. it reflects the expression that I am typing, but this is very distracting, as my cursor is jumping all over the place based on the width of the inlay hint.
@jrieken
Copy link
Member

jrieken commented Sep 24, 2021

Good catch... It almost feels like we should delay certain updates until a typing pause occurs. Or even better update but don't change the width while a line has a cursor

@jrieken jrieken added the feature-request Request for new features or functionality label Oct 4, 2021
@OldStarchy OldStarchy mentioned this issue Oct 19, 2021
Open
@jrieken jrieken added this to the January 2022 milestone Jan 7, 2022
jrieken added a commit that referenced this issue Jan 10, 2022
@jrieken
correctly cancel requests when typing triggers more, #133730
c536338
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 10, 2022
vscode: correctly cancel requests when typing triggers more, microsof…
10a63d5 
…t/vscode#133730

Commit: c536338811bd5e7cb89934387482c9ebaa4da49c
jrieken added a commit that referenced this issue Jan 11, 2022
@jrieken
use collapseOnReplaceEdit for inlay hint decorations so that they a…
6a8aa51 
…re removed swiftly when lines/words are deleted, #133730
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 11, 2022
vscode: use collapseOnReplaceEdit for inlay hint decorations so tha…
c83e5c5 
…t they are removed swiftly when lines/words are deleted, microsoft/vscode#133730

Commit: 6a8aa518cc10f7e0609e9a3b9e9ffc2079c6a570
jrieken added a commit that referenced this issue Jan 11, 2022
@jrieken
when not at a word, than try to bind an item to the next token range, #…
fb26a61 
…133730
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 11, 2022
vscode: when not at a word, than try to bind an item to the next toke…
6a77df6 
…n range, microsoft/vscode#133730

Commit: fb26a6122e71ab43bb4e94a6096c27a983819cd0
jrieken added a commit that referenced this issue Jan 20, 2022
@jrieken
while typing use fixed and conversative update delay for inlay hints, #…
f36bc0f 
…133730
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Jan 20, 2022
vscode: while typing use fixed and conversative update delay for inla…
724af91 
…y hints, microsoft/vscode#133730

Commit: f36bc0f1d449bde6fe3bb2e0e6e667e331b9d0aa
@jrieken
Copy link
Member

jrieken commented Jan 21, 2022

Closing after fixing a couple of things:

  • proper cancellation when typing starts a new request while one in flight
  • more careful listening to change events from the provider
  • high debounce rate (1.25sec) when typing

@jrieken jrieken closed this as completed Jan 21, 2022
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested and removed feature-request Request for new features or functionality labels Jan 24, 2022
@IanMatthewHuff IanMatthewHuff removed the verification-needed Verification of issue is requested label Jan 26, 2022
@IanMatthewHuff
Copy link
Member

Verified. Looks good to me now.
SmoothInlay

@IanMatthewHuff IanMatthewHuff added verification-needed Verification of issue is requested verified Verification succeeded labels Jan 26, 2022
@IanMatthewHuff
Copy link
Member

Sorry I had the process off and had removed verification-needed added it back in along with verified.

@jrieken jrieken mentioned this issue Feb 10, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug inlay-hints verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
January 2022
Development

No branches or pull requests
4 participants
@IanMatthewHuff @jrieken @hediet @alexdima