still show suggestions in string when disable string suggestion

[tjx666]

Version:

Version: 1.63.0-insider (Universal)
Commit: 552af97a0170b43c9323bec62211feb184da9749
Date: 2021-11-05T05:15:13.016Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Darwin x64 21.1.0

some config:

{
  "editor.lightbulb.enabled": false,
  "editor.linkedEditing": true,
  "editor.minimap.enabled": false,
  "editor.quickSuggestions": {
    "strings": false,
    "comments": false,
    "other": true
  },
  "editor.smoothScrolling": true,
  "editor.stickyTabStops": true,
  "editor.suggest.preview": true,
  "editor.suggest.shareSuggestSelections": true,
  "editor.suggest.snippetsPreventQuickSuggestions": false,
  "editor.suggestSelection": "first",
}

Steps to Reproduce:

1.reload VSCode with extension disable
2.open a ts file and type quote, the suggestions still display

[jrieken]

Looks like ' is registered as trigger character... Unsure if there is anything from TS. What's unhappy is that snippets are also invoked and showing. I need to remember why that was done

[mjbvz]

Yes we register ' as a trigger character for import paths:

vscode/extensions/typescript-language-features/src/languageFeatures/completions.ts

Line 642 in f1581dc

public static readonly triggerCharacters = ['.', '"', '\'', '`', '/', '@', '<', '#', ' '];

[jrieken]

What's unhappy is that snippets are also invoked and showing. I need to remember why that was done

Snippets are invoked with forgein trigger characters because of #37166

[DanTup]

This just came up for Dart too:

Dart-Code/Dart-Code#3670

Dart registers a bunch of trigger characters and because we can't make them conditional based on context, we check them on the server and return 0 completions if the context didn't make sense (for example, when / is the trigger, we won't return anything unless the location is within an import path). Of course, snippets can't do this.

The comments in #37166 suggest that snippets should only be showing up if the snippet starts with the trigger character, but that doesn't seem to be what's happening here.

[hediet]

Yes we register ' as a trigger character for import paths:

But this still works in stable. Has there been a recent change here?

[jrieken]

Yeah - there was a change in how prefixes to compare snippets against are determined. This is the PR: #136210. The challenge with snippets is that their insert positions aren't as well defined as with language completions. I have relaxed the rules and now more unwanted snippets show, esp after trigger characters. I am planning to fix this for November