-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge editor: preserve view state #150804
Labels
feature-request
Request for new features or functionality
merge-editor
merge-editor-workbench
verification-needed
Verification of issue is requested
verified
Verification succeeded
workbench-state
UI state across restarts
Milestone
Comments
jrieken
added a commit
that referenced
this issue
Jun 27, 2022
jrieken
added a commit
that referenced
this issue
Jun 27, 2022
To verify:
To get a merge conflict and editor
|
Sorry forgot to mention that it needs todays insiders. |
Still doesn't work... Need to investigate., sorry for the fuzz |
Sorry, my verification steps are bad. The find widget isn't part of any editor view state, selecting and folding etc is. So To verify:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
feature-request
Request for new features or functionality
merge-editor
merge-editor-workbench
verification-needed
Verification of issue is requested
verified
Verification succeeded
workbench-state
UI state across restarts
Testing #150389
Similar to #150791 where
BaseTextEditor
provides some helper methods for storing editor view state, the merge editor should associate view state like the diff editor does: e.g. selection, folding regions etc. so that they can restore after window reload.One thing that is special about the diff editor: when you open a diff editor for the first time, we automatically reveal the first diff and ignore any previous view state. This helps focussing on what has actually changed. However, when a diff editor was opened before and is just made active again, we do restore the view state.
The text was updated successfully, but these errors were encountered: