Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Editor: language status should show #151136

Closed
daviddossett opened this issue Jun 2, 2022 · 5 comments
Closed

Merge Editor: language status should show #151136

daviddossett opened this issue Jun 2, 2022 · 5 comments

Comments

@daviddossett
Copy link
Contributor

Testing #150389

I assume we hide the language picker right now since it wouldn't make sense to switch. Should we hide the entire status bar item including the {} button?

CleanShot 2022-06-02 at 10 05 30@2x

@hediet hediet added this to the June 2022 milestone Jun 2, 2022
@bpasero
Copy link
Member

bpasero commented Jun 3, 2022

I think the editor status entries should reflect the full scale of the result editor, same as we do for diff editors. For example changing the language mode changes it for all editors inside.

@daviddossett
Copy link
Contributor Author

That sounds reasonable then. Better than half of it being hidden, in any case.

@bpasero bpasero changed the title Merge Editor: language status should not show? Merge Editor: language status should show Jun 12, 2022
@bpasero bpasero self-assigned this Jun 12, 2022
@jrieken jrieken closed this as completed Jun 24, 2022
@bpasero
Copy link
Member

bpasero commented Jun 25, 2022

@jrieken fyi for the diff editor we apply the change to the language to both sides, maybe for merge editor it should apply to all 3 sides?

@jrieken
Copy link
Member

jrieken commented Jun 25, 2022

Yeah, I wasn't sure about that and went with the minimum - it's unlikely that you have language features in those readonly editors anyways. Well, except for tokens...

@jrieken
Copy link
Member

jrieken commented Jun 27, 2022

changed my mind: #153278

@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants