No custom hover for menu-only layout control

[jrieken]

re #150788

"workbench.layoutControl.enabled": true,
"workbench.layoutControl.type": "menu",

• use the config above
• hover over the layout control
• 🐛 native hover
• (any other value for .type uses the custom hover)

[sbatten]

This is actually because the SubmenuEntryActionViewItem extends BaseActionViewItem whereas the MenuEntryActionViewItem extends ActionViewItem.

ActionViewItem is what provides the custom hover capability.

Here is a quick summary of the ActionViewItem structure:

MenuEntryActionViewItem
ActionViewItem (handles hover delegate)
BaseActionViewItem (IActionViewItem)
Disposable

SubmenuEntryActionViewItem
DropdownMenuActionViewItem
BaseActionViewItem (IActionViewItem)
Disposable


**extends ActionViewItem**
ActionWithDropdownActionViewItem
MenuSeparatorActionViewItem
MenuEntryActionViewItem
ReactionActionViewItem
DropDownMenuActionViewItem
ToggleMultilineActionViewItem
QuickFixActionViewItem
NotebooKernelActionViewItem
StatusBarActionViewItem

**extends BaseActionViewItem**
ActionViewItem
SelectActionViewItem
DropdownMenuActionViewItem
BaseMenuActionViewItem
ToggleActionViewItem
DropdownWithPrimaryActionViewItem
DropdownWithDefaultActionViewItem
ActivityActionViewItem
StartDebugActionViewItem
ReplFilterActionViewItem
MarkersFilterActionViewItem
FolderSettingsActionViewItem
TestingExplorerFilter

There is no clear guidance on how to use these aside from the very recommended approach of using createActionViewItem when using a toolbar/actionbar. Ideally we could move to only one "BaseActionViewItem", then several reusable widgets that extend that.

[jrieken]

ActionViewItem is what provides the custom hover capability.

I have changed that (which closed this issue) but I am also in for making this all simpler. Something tells me that we should have a higher level (workbench, platform) "toolbar controller" that you just create a for a menu (id). Internally it would use the lower level widgets but it would do all the lifting and glue that today various util-functions do

[sandy081]

I still see native hover. I assume this is not expected.