Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong use of nls-utils in untitledTextEditorHint.ts #155293

Closed
jrieken opened this issue Jul 15, 2022 · 1 comment · Fixed by #155321
Closed

Wrong use of nls-utils in untitledTextEditorHint.ts #155293

jrieken opened this issue Jul 15, 2022 · 1 comment · Fixed by #155321
Assignees
@jrieken @sbatten
Labels
insiders-released Patch has been released in VS Code Insiders
Milestone
July 2022

Comments

@jrieken
Copy link
Member

jrieken commented Jul 15, 2022

  • src/vs/workbench/contrib/codeEditor/browser/untitledTextEditorHint.ts
  • there is string concatenation of nls-strings, like this and much more
  • This is usually wrong because it assumes that all languages use similar sequences. The localize-function support replacements for cases like this and in this specific case we might be better off using a markdown string with command-links

/cc @isidorn who original did this: please speak up if there is more code like this
jrieken added a commit that referenced this issue Jul 15, 2022
@jrieken
add "start with snippet" to empty editor text, change things to use f…
92329e4 
…ormatted text renderer (fixes #155293)
@jrieken jrieken self-assigned this Jul 15, 2022
@jrieken
Copy link
Member Author

jrieken commented Jul 15, 2022

I have some changes in joh/innocent-tiger that will fix this

@jrieken jrieken mentioned this issue Jul 15, 2022
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 15, 2022
@vscodenpa vscodenpa added this to the July 2022 milestone Jul 15, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 18, 2022
jrieken added a commit that referenced this issue Jul 18, 2022
@jrieken
add "start with snippet" to empty editor text, change things to use f…
0b734bf 
…ormatted text renderer (fixes #155293)
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@sbatten sbatten

Labels
insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

joh/innocent tiger microsoft/vscode
3 participants
@jrieken @sbatten @vscodenpa