Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should rename treeSupportsFind to listSupportsFind #156878

Closed
bpasero opened this issue Aug 2, 2022 · 2 comments
Closed

Should rename treeSupportsFind to listSupportsFind #156878

bpasero opened this issue Aug 2, 2022 · 2 comments
Assignees
Labels
candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Aug 2, 2022

I think this came up during the standup today, why is the context key called treeSupportsFind and not listSupportsFind?

//cc @alexdima

@alexdima
Copy link
Member

alexdima commented Aug 2, 2022

This context key came in quite late via a fix -- #156637 . I noticed this standing out because of the default keybindings which seem to mix things up:

{ "key": "f3",                    "command": "list.find",
                                     "when": "listFocus && treeSupportsFind" },
{ "key": "cmd+f",                 "command": "list.find",
                                     "when": "listFocus && treeSupportsFind" },

Giving this a candidate in case we want to align the context key before shipping stable

@alexdima alexdima added the candidate Issue identified as probable candidate for fixing in the next release label Aug 2, 2022
@alexdima alexdima added this to the July 2022 milestone Aug 2, 2022
@bpasero
Copy link
Member Author

bpasero commented Aug 2, 2022

From e8ee2cf

rebornix added a commit that referenced this issue Aug 2, 2022
Fix #156878. Update list support find context key name
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 2, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

No branches or pull requests

5 participants