Debug: Logpoint: Intellisense

[PrimeTime416]

Please allow for intellisense when entering in the Log Message Template Section {}, currently is says No Suggestions. Thanks!

[vscodenpa]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[sujyotraut]

This feature will make debugging in vscode a lot better experience & improve productivity.
We appreciate this feature.

[vscodenpa]

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[vscodenpa]

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[colin-grant-work]

It may be worth adding here that this was not a request for new functionality. This functionality is already implemented but is broken - I suspect due to changes in the bracket system.

vscode/src/vs/workbench/contrib/debug/browser/breakpointWidget.ts

Lines 247 to 277 in 61532ae

	provideCompletionItems: (model: ITextModel, position: Position, _context: CompletionContext, token: CancellationToken): Promise<CompletionList> => {
	let suggestionsPromise: Promise<CompletionList>;
	const underlyingModel = this.editor.getModel();
	if (underlyingModel && (this.context === Context.CONDITION || (this.context === Context.LOG_MESSAGE && isPositionInCurlyBracketBlock(this.input)))) {
	suggestionsPromise = provideSuggestionItems(this.languageFeaturesService.completionProvider, underlyingModel, new Position(this.lineNumber, 1), new CompletionOptions(undefined, new Set<CompletionItemKind>().add(CompletionItemKind.Snippet)), _context, token).then(suggestions => {
	let overwriteBefore = 0;
	if (this.context === Context.CONDITION) {
	overwriteBefore = position.column - 1;
	} else {
	// Inside the currly brackets, need to count how many useful characters are behind the position so they would all be taken into account
	const value = this.input.getModel().getValue();
	while ((position.column - 2 - overwriteBefore >= 0) && value[position.column - 2 - overwriteBefore] !== '{' && value[position.column - 2 - overwriteBefore] !== ' ') {
	overwriteBefore++;
	}
	}
	return {
	suggestions: suggestions.items.map(s => {
	s.completion.range = Range.fromPositions(position.delta(0, -overwriteBefore), position);
	return s.completion;
	})
	};
	});
	} else {
	suggestionsPromise = Promise.resolve({ suggestions: [] });
	}
	return suggestionsPromise;
	}
	}));

That code clearly indicates that if the context is a log message and isPositionInCurlyBracketBlock(this.input), completions should be provided. That they are not being provided is a bug.

@roblourens, in case closed issues are silenced.

[roblourens]

Thanks for pointing that out, I agree this actually looks broken. @hediet it looks like you changed the bracket detection logic, could you take a look?

[hediet]

This actually works for symbols:

Member completion never worked here and will probably never be supported.
The reason for this is that typescript cannot offer contextual member completion for strings outside of source files.

[colin-grant-work]

@hediet, what you're seeing is not what I'm seeing in 1.72.2. For me, no suggestions are ever provided for a log point in a TS file, whether it's a member reference or not:

[vince-fugnitto]

@roblourens @hediet like Colin mentioned I'm not getting any completions whatsoever for logpoints when using v1.72.2.

[colin-grant-work]

@hediet, To provide a little more detail, the problem is definitely in the bracket system:

Here I'm debugging when I hit ctrl+i in the breakpoint widget. It's hitting the conditional check at line 250 in the code I posted above, and it succeeds until it hits the check for whether it's in brackets, and that check returns false, though my cursor is obviously inside curly brackets.

[hediet]

I can reproduce now after clearing my settings.

As stupid as it sounds, it works with this setting:

"[plaintext]": {
    "editor.language.colorizedBracketPairs": [
        ["{", "}"]
    ]
},

[hediet]

Fixed by #170497