Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screen cheese: Show Disabled action in the toolbar is not shown completely #158854

Closed
sandy081 opened this issue Aug 23, 2022 · 3 comments · Fixed by #159721
Closed

Screen cheese: Show Disabled action in the toolbar is not shown completely #158854

sandy081 opened this issue Aug 23, 2022 · 3 comments · Fixed by #159721
Assignees
@mjbvz @justschen
Labels
bug Issue identified by VS Code Team member as probable bug editor-code-actions Editor inplace actions (Ctrl + .) insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
September 2022

Comments

@sandy081
Copy link
Member

Testing #158636

In the Refactor Menu

image
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Aug 23, 2022
@mjbvz mjbvz modified the milestones: August 2022, September 2022 Aug 23, 2022
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 23, 2022

Moving to September. I think rendering needs a different approach where the action bar is not part of the main list

@justschen
Copy link
Contributor

Initially, to counter this, I gave it a default min-width (when the option to show/disable actions was available). Not sure if that PX size was just incorrect or if it didn't get fixed the way I intended.

Regardless, I do think that in retrospect, having the action bar just be appended at the bottom of the list instead of being in the List Widget renderElement might work better.

@mjbvz mjbvz added the editor-code-actions Editor inplace actions (Ctrl + .) label Aug 30, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Sep 1, 2022
@mjbvz
Refactor code action widget
a04905c 
Refactors the code action widget somewhat heavily. The goal was to move the documentation items out of the main list widget

While doing this, I also tried to clean up the code to be safer (less state) and more readable

Fixes microsoft#158855
Fixes microsoft#158854
@mjbvz mjbvz mentioned this issue Sep 1, 2022
Merged
mjbvz added a commit that referenced this issue Sep 1, 2022
@mjbvz
Refactor code action widget (#159721)
44c59c7 
Refactors the code action widget somewhat heavily. The goal was to move the documentation items out of the main list widget

While doing this, I also tried to clean up the code to be safer (less state) and more readable

Fixes #158855
Fixes #158854
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 1, 2022
@IanMatthewHuff IanMatthewHuff added the verified Verification succeeded label Sep 29, 2022
@IanMatthewHuff
Copy link
Member

Looks good now.
image

@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

@justschen justschen

Labels
bug Issue identified by VS Code Team member as probable bug editor-code-actions Editor inplace actions (Ctrl + .) insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

Refactor code action widget mjbvz/vscode
5 participants
@IanMatthewHuff @sandy081 @mjbvz @justschen @vscodenpa