Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift+Tab from toolbar is running the code action #158857

Closed
sandy081 opened this issue Aug 23, 2022 · 2 comments · Fixed by #158956
Closed

Shift+Tab from toolbar is running the code action #158857

sandy081 opened this issue Aug 23, 2022 · 2 comments · Fixed by #158956
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@sandy081
Copy link
Member

Testing #158636

Kapture.2022-08-23.at.09.45.04.mp4
@mjbvz
Copy link
Collaborator

mjbvz commented Aug 23, 2022

@justschen Do you remember why we added the shift + tab keybinding? The suggest widget uses it to accept suggestions in alternative mode, not normal suggestions

@mjbvz mjbvz added this to the August 2022 milestone Aug 23, 2022
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Aug 23, 2022
@justschen
Copy link
Contributor

@mjbvz I think I might have accidentally added it in when templating registerEditorCommand functions. It has the secondary keybindings, but I think can just get removed entirely.

registerEditorCommand(new CodeActionContribution({

registerEditorCommand(new CodeActionContribution({
	id: 'onEnterSelectCodeAction',
	precondition: Context.Visible,
	handler(x) {
		x.selectedOption();
	},
	kbOpts: {
		weight: weight + 100000,
		primary: KeyCode.Enter,
		secondary: [KeyMod.Shift | KeyCode.Tab],
	}
}));

mjbvz added a commit to mjbvz/vscode that referenced this issue Aug 23, 2022
mjbvz added a commit that referenced this issue Aug 24, 2022
* Allos ctrl+. to accept current code aciton

Fixes #7512

* Remove shift+tab binding

Fixes #158857
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 24, 2022
@andreamah andreamah added the verified Verification succeeded label Aug 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants