Task reconnection status does not work for default build task

[bpasero]

I urge to selfhost on this for a bit. Status bar never shows the state for me, I think never has after window reload.

[meganrogge]

how often do you see this? I've tried a lot to repro and haven't seen it yet.

If you see it often, could you pls turn on trace logging?

[bpasero]

@meganrogge here are my steps that should allow you to reproduce:

• run code-insiders from an empty fresh --user-data-dir
• open vscode folder
• hit Cmd+Shift+B
• notice the task bar showing 2 tasks and "Building..."
• reload the window
• notice the status bar not showing those entries

In your case, you likely have terminals panel visible, but I never have terminals visible typically.

[meganrogge]

Thanks @bpasero when you eventually do open the panel, do the statuses appear? I think I saw what you describe but upon opening the panel, the statuses appeared

[meganrogge]

I can repro the statuses not appearing in the status bar until I open the panel

[meganrogge]

that's because the tasks aren't reconnected to until the terminals are restored, which doesn't happen when the panel is hidden

vscode/src/vs/workbench/contrib/terminal/browser/terminalView.ts

Line 179 in 80bc53a

this._terminalService.initializeTerminals();

vscode/src/vs/workbench/contrib/terminal/browser/terminalView.ts

Lines 165 to 191 in 80bc53a

	this._register(this.onDidChangeBodyVisibility(async visible => {
	this._viewShowing.set(visible);
	if (visible) {
	const hadTerminals = !!this._terminalGroupService.groups.length;
	// Ensure the primary backend is registered as it's important to do before
	// initializeTerminals is called.
	await this._terminalService.primaryBackendRegistered;
	if (this._terminalService.isProcessSupportRegistered) {
	if (this._terminalsInitialized) {
	if (!hadTerminals) {
	this._terminalService.createTerminal({ location: TerminalLocation.Panel });
	}
	} else {
	this._terminalsInitialized = true;
	this._terminalService.initializeTerminals();
	}
	} else {
	this._onDidChangeViewWelcomeState.fire();
	}
	// we don't know here whether or not it should be focused, so
	// defer focusing the panel to the focus() call
	// to prevent overriding preserveFocus for extensions
	this._terminalGroupService.showPanel(false);
	} else {
	for (const instance of this._terminalGroupService.instances) {
	instance.resetFocusContextKey();
	}

[bpasero]

Yes, in all my issues with this, panel is never opened on startup. I typically keep it closed always.

[sandy081]

I do not think it is working as expected.

• I see the terminal is shown automatically after reload (even if I have it closed before reload)
• Status bar does not show the tasks info
• I do not see the building (progress icon) on the tasks in the terminal

Please see the recording

Kapture.2022-10-27.at.15.57.45.mp4

[jeanp413]

Created a PR fixing this #165110