Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch internal VS Code tests off of NotebookContentProvider api #160580

Closed
mjbvz opened this issue Sep 9, 2022 · 1 comment · Fixed by #165195
Closed

Switch internal VS Code tests off of NotebookContentProvider api #160580

mjbvz opened this issue Sep 9, 2022 · 1 comment · Fixed by #165195
Assignees
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders interactive-window notebook
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 9, 2022

The notebook content provider api is being removed: #147248

However it looks like a few of our tests are still using it:

const apiTestContentProvider: vscode.NotebookContentProvider = {
openNotebook: async (resource: vscode.Uri): Promise<vscode.NotebookData> => {

const apiTestContentProvider: vscode.NotebookContentProvider = {

const complexContentProvider = new class implements vscode.NotebookContentProvider {

context.subscriptions.push(vscode.workspace.registerNotebookContentProvider('notebookSmokeTest', {

@mjbvz mjbvz added the debt Code quality issues label Sep 9, 2022
@rebornix
Copy link
Member

Along with the use of content provider in tests, we also need to remove the content provider used by Interactive Window.

@rebornix rebornix added this to the November 2022 milestone Oct 21, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Oct 31, 2022
mjbvz added a commit to mjbvz/vscode that referenced this issue Oct 31, 2022
For microsoft#160580

Also remove one test that is no longer relevant
mjbvz added a commit that referenced this issue Oct 31, 2022
mjbvz added a commit that referenced this issue Oct 31, 2022
For #160580

Also remove one test that is no longer relevant
mjbvz added a commit to mjbvz/vscode that referenced this issue Nov 1, 2022
mjbvz added a commit that referenced this issue Nov 2, 2022
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Nov 2, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues insiders-released Patch has been released in VS Code Insiders interactive-window notebook
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants