Cannot open notebook in vscode.dev, error reading property message

[lramos15]

Started up insiders.vscode.dev for the first time in awhile and received the following error

Seems to come from here.

vscode/src/vs/workbench/contrib/notebook/browser/notebookEditor.ts

Lines 293 to 294 in 0944a16

	const error = createErrorWithActions(e instanceof Error ? e : new Error(e.message), [
	toAction({

This only repros when I use the endgame vscode.dev query provided. Opening the file myself seems to work

[rebornix]

@lramos15 do you see this every time when opening the link? It seems that it throws with an undefined error but we failed to read the error message. It didn't explain why the file opening fails though.

[lramos15]

@lramos15 do you see this every time when opening the link? It seems that it throws with an undefined error but we failed to read the error message. It didn't explain why the file opening fails though.

I see it every time. I can try again tomorrow when this change goes in to see if there is a more detailed error message.

[joyceerhl]

I just hit this as well twice @rebornix but third time didn't repro

[joyceerhl]

This will fail
https://insiders.vscode.dev/github/microsoft/vscode/blob/9f5d3eb1353f6e6bd5ab7bccab9d50b0aba15209/.vscode/notebooks/endgame.github-issues#C22:L1

This is OK
https://insiders.vscode.dev/github/microsoft/vscode/blob/9f5d3eb1353f6e6bd5ab7bccab9d50b0aba15209/.vscode/notebooks/endgame.github-issues#C23:L1

We think it's because C22 is a markdown cell and C23 is a code cell

How it looks: the editor progress bar spins forever, when you start scrolling the error modal dialog pops up
It's quite possible this was always there but is more visible now that we're using vscode.dev notebook cell deeplinks

[rebornix]

I prepared a fix for this one, by turning the cell into editing mode if there is a selection in the link #164758. If we drop L1 from the link, you can find it open successfully.

However currently whenever we copy a link from a markdown cell preview, we always append L1 ion the link, we should probably only append line number when the cell is in editing mode, tracked in https://github.com/microsoft/vscode-dev/issues/749