Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peek Call Hierarchy - close button not working #165646

Closed
arknest opened this issue Nov 6, 2022 · 6 comments
Closed

Peek Call Hierarchy - close button not working #165646

arknest opened this issue Nov 6, 2022 · 6 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug callhierarchy verified Verification succeeded
Milestone
November 2022

Comments

@arknest
Copy link

arknest commented Nov 6, 2022

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.74.0-insider
  • Commit: e764c5b
  • Date: 2022-11-04T05:18:32.818Z
  • OS Version: Windows_NT x64 6.3.9600 (server 2012 r2)

Steps to Reproduce:

  1. Right click on function in text editor (in typescript file)
  2. choose "Peek Call Hierarchy"
  3. inline "Peek" window opens
  4. close button is greyed out and unable to close window
@jrieken jrieken added info-needed Issue requires more information from poster callhierarchy labels Nov 7, 2022
@jrieken
Copy link
Member

jrieken commented Nov 7, 2022

I cannot reproduce. Please check the dev tools console for error (F1 > Developer Tools > Console)

@arknest
Copy link
Author

arknest commented Nov 7, 2022

ecJWXgvo5Y

At startup (with --disable-extensions):
Code_-_Insiders_05je28lkfc
vscode-app-1667841972505.log

Then when "Peek Call Hierarchy" pressed:
Code_-_Insiders_jsUq0rraa1
vscode-app-1667842102881.log

@arknest
Copy link
Author

arknest commented Nov 7, 2022

By the way, pressing ESC does not closes the window as well

@jrieken
Copy link
Member

jrieken commented Nov 8, 2022

@arknest Do you have the config.editor.stablePeek-setting enabled?

@jrieken jrieken added this to the November 2022 milestone Nov 8, 2022
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Nov 8, 2022
@jrieken
Copy link
Member

jrieken commented Nov 8, 2022

I can reproduce with the setting mentioned about and will push a fix. @arknest let we know if you don't use that setting

@jrieken jrieken mentioned this issue Nov 8, 2022
Merged
jrieken added a commit that referenced this issue Nov 8, 2022
@jrieken
don't disable the close button for peek
efe3aca 
#165646
jrieken added a commit that referenced this issue Nov 8, 2022
@jrieken
don't disable the close button for peek (#165826)
3cd5166 
#165646
@arknest
Copy link
Author

arknest commented Nov 9, 2022

@arknest Do you have the config.editor.stablePeek-setting enabled?

Yes, I have it enabled.
When switched to default (false) it works as expected.

@arknest arknest closed this as completed Nov 9, 2022
@amunger amunger added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug callhierarchy verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

No branches or pull requests
3 participants
@jrieken @amunger @arknest