Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff editor have no more close button #167270

Closed
jrieken opened this issue Nov 25, 2022 · 4 comments · Fixed by #167277
Closed

Diff editor have no more close button #167270

jrieken opened this issue Nov 25, 2022 · 4 comments · Fixed by #167277
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders menus Menu items and widget issues verified Verification succeeded
Milestone
November 2022

Comments

@jrieken
Copy link
Member

jrieken commented Nov 25, 2022

  • disable workbench tabs
  • install gitlens
  • open a diff editor
  • there is so many commands that the split and close button overflow into the secondary menu

Screenshot 2022-11-25 at 16 56 23
@jrieken jrieken assigned jrieken and unassigned bpasero Nov 25, 2022
jrieken added a commit that referenced this issue Nov 25, 2022
@jrieken
move max menu/toolbar size into Toolbar itself, hidden item don't cou…
e64c658 
…nt against limit

fixes #167270
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug menus Menu items and widget issues labels Nov 25, 2022
@jrieken
Copy link
Member Author

jrieken commented Nov 25, 2022

This is technically caused by extension but also annoying. I am building on the new'ish support to hide menu items and such don't count against the limit anymore

@jrieken jrieken added this to the November 2022 milestone Nov 25, 2022
@jrieken
Copy link
Member Author

jrieken commented Nov 25, 2022 •
edited
Loading

To verify:

  • follow the steps above
  • make sure you can hide menus items (right-click > hide) so that split and close appear again

@jrieken jrieken mentioned this issue Nov 25, 2022
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 25, 2022
@sandy081 sandy081 added the verified Verification succeeded label Dec 1, 2022
@sandy081
Copy link
Member

sandy081 commented Dec 1, 2022

Does the split and close actions shall not be checked?

image

@jrieken
Copy link
Member Author

jrieken commented Dec 1, 2022

The checked state represents the hiding that's done by a user while overflowing is just a space constraint. I believe the activity bar behaves the same

@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders menus Menu items and widget issues verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

move max menu/toolbar size into Toolbar itself, hidden item don't cou… microsoft/vscode
4 participants
@bpasero @jrieken @sandy081 @vscodenpa