Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registering a fs provider shouldn't cause a dom layout in the breadcrumbs #169875

Closed
alexdima opened this issue Dec 22, 2022 · 1 comment
Closed

Registering a fs provider shouldn't cause a dom layout in the breadcrumbs #169875

alexdima opened this issue Dec 22, 2022 · 1 comment
Assignees
@jrieken
Labels
breadcrumbs bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders perf perf-startup verified Verification succeeded
Milestone
January 2023

Comments

@alexdima
Copy link
Member

  • profile on startup and have a css file opened
  • the EditSessionsContribution registers a fs provider for vscode-edit-sessions
  • this somehow ends up causing a dom layout via the breadcrumbs

image
@jrieken jrieken assigned aeschli and unassigned aeschli Dec 23, 2022
@jrieken
Copy link
Member

jrieken commented Dec 23, 2022

The trigger is that registering a file system causes a label service change event which causes breadcrumbs to re-render. Tho, we can likely optimise this

@jrieken jrieken mentioned this issue Jan 9, 2023
Closed
@jrieken jrieken added this to the January 2023 milestone Jan 9, 2023
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jan 9, 2023
jrieken added a commit that referenced this issue Jan 9, 2023
@jrieken
don't update breadcrumbs on each and every file system registration
5795544 
fixes #169875
@jrieken jrieken closed this as completed in 67fd9d1 Jan 9, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 9, 2023
@connor4312 connor4312 added the verified Verification succeeded label Jan 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
breadcrumbs bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders perf perf-startup verified Verification succeeded
Projects
None yet
Milestone
January 2023
Development

No branches or pull requests
5 participants
@jrieken @connor4312 @alexdima @aeschli @vscodenpa