Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inlay Hints are shown briefly when navigating in peek window #177059

Closed
DanTup opened this issue Mar 14, 2023 · 11 comments
Closed

Inlay Hints are shown briefly when navigating in peek window #177059

DanTup opened this issue Mar 14, 2023 · 11 comments
Assignees
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug inlay-hints insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@DanTup
Copy link
Contributor

DanTup commented Mar 14, 2023

This came up at Dart-Code/Dart-Code#4436 (comment) and I can reproduce myself.

In Dart we've set inlay hints to offUnlessPressed because they can be noisy with the VS Code's always-on default.

When opening Peek windows, the inlay hints appear briefly then disappear. Then while navigating between references the same happens:

Screen.Recording.2023-03-13.at.19.11.35.mov

I can repro this using only the mouse, so at no point is the Inlay Hints keybinding held down.

@jrieken
Copy link
Member

jrieken commented Mar 16, 2023

I cannot reproduce. How is offUnlessPressed set?

@DanTup
Copy link
Contributor Author

DanTup commented Mar 16, 2023

It's set using configurationDefaults in the extension's package.json:

https://github.com/Dart-Code/Dart-Code/blob/70775b5547f858036fab581eaffbea77763b99f2/package.json#L1363-L1371

@DanTup
Copy link
Contributor Author

DanTup commented Mar 16, 2023

(note: it's set only for Dart specifically... I wondered whether the Peek window might start rendering without having its language set? 🤔)

@incendial
Copy link

From my personal experience it's not just about the Peek window. I can see the inlay hints blinking when I open a file (but rarely), when I compare a file changes in "source control" tab and so on.

@vscodenpa
Copy link

Hey @jrieken, this issue might need further attention.

@DanTup, you can help us out by closing this issue if the problem no longer exists, or adding more information.

@DanTup
Copy link
Contributor Author

DanTup commented Jun 8, 2023

@incendial are you still seeing this? I don't seem to be able to repro now - although I'm on Windows atm, not sure if that makes a difference.

@incendial
Copy link

Yes,

Screen.Recording.2023-06-09.at.18.43.34.mov

@DanTup
Copy link
Contributor Author

DanTup commented Jun 13, 2023

Yeah, I can also repro on my Mac. Not sure if it's because my PC is faster I don't see it or if there's some other difference on Windows.

Jun-13-2023 12-22-28

@jrieken can you reproduce this using the setting configured as a configurationDefault as noted above?

EdiT: It only appears on the first click.. although my GIF looks like repeated clicks trigger it, that's just because it's looping the first click.

@vscodenpa
Copy link

Hey @jrieken, this issue might need further attention.

@DanTup, you can help us out by closing this issue if the problem no longer exists, or adding more information.

@vscodenpa
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Sep 9, 2023
@jrieken jrieken reopened this Sep 11, 2023
@jrieken jrieken removed the info-needed Issue requires more information from poster label Sep 11, 2023
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Dec 4, 2023
@jrieken jrieken added this to the December 2023 milestone Dec 4, 2023
jrieken added a commit that referenced this issue Dec 4, 2023
@jrieken jrieken closed this as completed in d5fe767 Dec 4, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Dec 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2024
@roblourens roblourens added the author-verification-requested Issues potentially verifiable by issue author label Jan 25, 2024
@microsoft microsoft unlocked this conversation Jan 25, 2024
@vscodenpa
Copy link

This bug has been fixed in the latest release of VS Code Insiders!

@DanTup, you can help us out by commenting /verified if things are now working as expected.

If things still don't seem right, please ensure you're on version 3dea5cb of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@mjbvz mjbvz added the verified Verification succeeded label Jan 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
author-verification-requested Issues potentially verifiable by issue author bug Issue identified by VS Code Team member as probable bug inlay-hints insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants