show defaultColorDecorators in documents decorated by extensions

[olets]

If an extension decorates a document, none of document's defaultColorDecorators are shown.

A helpful enhancement would be to use the union of defaultColorDecorators and extension-provided decorators. Whereas currently the defaultColorDecorators are default at the document level, they would be default at the token level. So tokens with defaultColorDecorators decoration definitions and no decoration definitions from extensions would be decorated by the defaultColorDecorators.

• A practical example: [IntelliSense] Compatibility with `editor.defaultColorDecorators` setting tailwindlabs/tailwindcss#11212

[aeschli]

The idea is that contributed color providers have real language knowledge and know about the valid color formats and locations.

Maybe the tailwind extension is missing a color and should fix that?

[gyurielf]

The idea is that contributed color providers have real language knowledge and know about the valid color formats and locations.

Maybe the tailwind extension is missing a color and should fix that?

@bradlc possibly can answer this.

[olets]

We may be misunderstanding each other. My request is that extensions be able to extend a given language's default color decorators. Is it correct that currently if a user installs an extension which adds decorators to a given language, only the decorators contributed by the extension are used by VS Code for that language?

[aeschli]

The color ranges of all extensions are combined. So it's possible to write an extension that adds additional color ranges.

However, defaultColorDecorators are only used when there is no extension that provides color ranges for the given document.

[olets]

Thanks!

In those terms, my feature request is to have defaultColorDecorators' color ranges included in the combined color range for a language even when an extension provides color ranges for that language. It could be an additional option, or always when editor.defaultColorDecorators is true.

At a minimum, revising the label in the settings' GUI to include cover your "however" could help users know what to expect. (In my case, it would have helped me understand why toggling on the new option resulted in default decorators appearing only until extensions were fully loaded.)

[gyurielf]

Related (or duplicated):
#182534

[vscodenpa]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[vscodenpa]

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[olets]

Excited to see activity here! Looks like the issue was closed prematurely by PR keyword. Could we reopen until the change is released? cc @aiday-mar

[aiday-mar]

The change will be released tomorrow in Insiders :) and soon in stable

[dbaeumer]

@aiday-mar The PR got merged into main so I assume this goes into January and not November. Please ping if this is uncorrect and open a candidate issue if this is something for November.

[aiday-mar]

Hi @dbaeumer yes January is correct

[aiday-mar]

To verify:

• find the setting editor.defaultColorDecorators
• check that the setting has three values and that changing the value makes the decorators work as described in the settings