Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP textDocument/documentColor requests not being sent since v1.78 #182534

Closed
bradlc opened this issue May 15, 2023 · 1 comment · Fixed by #182625
Closed

LSP textDocument/documentColor requests not being sent since v1.78 #182534

bradlc opened this issue May 15, 2023 · 1 comment · Fixed by #182625
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-color-picker Editor color picker widget issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@bradlc
Copy link

bradlc commented May 15, 2023

Does this issue occur when all extensions are disabled?: Yes (all extensions other than the reproduction extension)

  • VS Code Version: 1.78.2
  • OS Version: macOS 12.5.1

Over at the Tailwind CSS IntelliSense repo we are seeing multiple reports of issues with colour decorators since the release of v1.78. Some are related to the new defaultColorDecorators setting which I think is a separate issue, but we are also seeing an issue where document colour requests are not being sent to the language server at all (defaultColorDecorators is false in this case).

I was able to create a small reproduction based on the LSP extension sample. Please see below.

Steps to Reproduce:

  1. Clone https://github.com/bradlc/vscode-document-colors
  2. Follow instructions from reproduction readme: https://github.com/bradlc/vscode-document-colors/blob/main/README.md

When the same project is opened in v1.76.2, the onDocumentColor count is logged repeatedly when editing the document.

@aeschli
Copy link
Contributor

aeschli commented May 16, 2023

Thanks a lot for the great steps to reproduce. I pushed a fix for the issue.

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels May 16, 2023
@ulugbekna ulugbekna added the verified Verification succeeded label May 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-color-picker Editor color picker widget issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants