Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: several webpacked JS files in extensions/ no longer build deterministically #189124

Closed
brjsp opened this issue Jul 28, 2023 · 0 comments · Fixed by #189959
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded vscode-build VS Code build process issues
Milestone

Comments

@brjsp
Copy link

brjsp commented Jul 28, 2023

Starting with version 1.80, Code no longer builds reproducibly. The following is a partial list of files that are wildly different on each rebuild (mostly different mangled variable names):

extensions/css-language-features/client/dist/node/cssClientMain.js
extensions/css-language-features/server/dist/node/cssServerMain.js
extensions/emmet/dist/node/emmetNodeMain.js
extensions/extension-editing/dist/extensionEditingMain.js
extensions/git/dist/askpass-main.js
extensions/git/dist/git-editor-main.js
extensions/git/dist/main.js
extensions/git-base/dist/extension.js
extensions/github/dist/extension.js
extensions/html-language-features/client/dist/node/htmlClientMain.js
extensions/json-language-features/client/dist/node/jsonClientMain.js
extensions/json-language-features/server/dist/node/jsonServerMain.js
extensions/markdown-language-features/server/dist/node/workerMain.js
extensions/media-preview/dist/extension.js
extensions/merge-conflict/dist/mergeConflictMain.js
extensions/npm/dist/npmMain.js
extensions/php-language-features/dist/phpMain.js
extensions/references-view/dist/extension.js
extensions/typescript-language-features/dist/extension.js

I maintain the Code OSS packages in openSUSE. Learn more about why reproducible builds are important.

brjsp added a commit to brjsp/vscodium that referenced this issue Jul 28, 2023
This also fixes the reproducibility issue mentioned in microsoft/vscode#189124
@mjbvz mjbvz added this to the August 2023 milestone Aug 8, 2023
mjbvz added a commit to mjbvz/vscode that referenced this issue Aug 8, 2023
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug vscode-build VS Code build process issues labels Aug 8, 2023
mjbvz added a commit that referenced this issue Aug 8, 2023
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 8, 2023
@jrieken jrieken added the verified Verification succeeded label Aug 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded vscode-build VS Code build process issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants