Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command center window title with newline #201340

Closed
roblourens opened this issue Dec 21, 2023 · 3 comments
Closed

Command center window title with newline #201340

roblourens opened this issue Dec 21, 2023 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug command-center insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@roblourens
Copy link
Member

  • Open the multi-diff editor from the Timeline view
  • See a messed up window title, I think due to the editor title having a newline in it
image
@lszomoru lszomoru added the bug Issue identified by VS Code Team member as probable bug label Dec 21, 2023
@hediet
Copy link
Member

hediet commented Jan 3, 2024

For me, it justs contains the workspace name (vscode):

Image

However, the multi file diff editor indeed might get a multi line title (commit.message might have \ns):

arguments: [`${item.shortRef} - ${commit.message}`, args, options]

@hediet hediet removed their assignment Jan 3, 2024
@roblourens
Copy link
Member Author

I have "window.title": "${dirty} ${activeEditorShort}${separator}${rootName}" if that matters

@jrieken jrieken added this to the December / January 2024 milestone Jan 8, 2024
jrieken added a commit that referenced this issue Jan 8, 2024
@jrieken
Copy link
Member

jrieken commented Jan 8, 2024

repro steps

  • have a commit which message uses new lines
  • configure "window.title": "${dirty} ${activeEditorShort}${separator}${rootName}" and "multiDiffEditor.experimental.enabled": true
  • open the multi diff editor for a file in said commit
  • the command center looks bad

@jrieken jrieken closed this as completed in 1350b6e Jan 8, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 8, 2024
@roblourens roblourens added the verified Verification succeeded label Jan 24, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
@microsoft microsoft locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug command-center insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants