Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accessibility] Use aria-label for "Regenerate" button in inline Copilot chat #201527

Closed
jooyoungseo opened this issue Dec 27, 2023 · 1 comment · Fixed by #202127
Closed

[Accessibility] Use aria-label for "Regenerate" button in inline Copilot chat #201527

jooyoungseo opened this issue Dec 27, 2023 · 1 comment · Fixed by #202127
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded

Comments

@jooyoungseo
Copy link

jooyoungseo commented Dec 27, 2023

Type: Bug

CC @meganrogge

In inline Copilot chat, "Regenerate" button is not readable by some screen readers, such as JAWS. This is because the button is labeled with title attribute. Please add aria-label so that JAWS can recognize the label.

For better communication, I have recorded a gif:

Recording 2023-12-26 at 19 00 48

VS Code version: Code - Insiders 1.86.0-insider (9621add, 2023-12-20T05:36:57.756Z)
OS version: Windows_NT x64 10.0.22631
Modes:

System Info
Item Value
CPUs 11th Gen Intel(R) Core(TM) i5-1145G7 @ 2.60GHz (8 x 2611)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 15.71GB (4.92GB free)
Process Argv --crash-reporter-id b05b88e5-8894-4031-ae34-fa034ebddea9
Screen Reader yes
VM 0%
Extensions (116)
Extension Author (truncated) Version
vscode-openapi 42C 4.19.2
android-dev-ext ade 1.3.2
aiprm-lang AIP 0.0.2
Bookmarks ale 13.4.2
openscad Ant 1.2.2
spellright ban 3.0.118
zoterolatex bna 0.4.1
mermaid-markdown-syntax-highlighting bpr 1.6.0
doxdocgen csc 1.4.0
vscode-markdownlint Dav 0.53.0
vscode-eslint dba 2.4.2
vscode-quick-select dba 0.2.9
vscode-deno den 3.30.0
gitlens eam 14.6.1
EditorConfig Edi 0.16.4
prettier-vscode esb 10.1.0
vscode-firefox-debug fir 2.9.10
shell-format fox 7.2.5
vscode-google-translate fun 1.4.13
codespaces Git 1.16.5
copilot Git 1.143.601
copilot-chat Git 0.12.2023122001
remotehub Git 0.62.0
vscode-github-actions git 0.26.2
vscode-pull-request-github Git 0.79.2023122012
cloudcode goo 2.2.1
overleaf-workshop iam 0.6.1
cslpreview igo 0.2.2
easy-snippet inu 0.7.5
path-autocomplete ion 1.25.0
latex-workshop Jam 9.16.1
lilypond-syntax jea 0.1.1
scheme jea 0.2.0
better-cpp-syntax jef 1.17.2
language-julia jul 1.65.2
google-search kam 0.0.1
vscode-lua-format Koi 1.3.8
lilypond-formatter lhl 0.2.3
lilypond-pdf-preview lhl 0.2.8
lilypond-snippets lhl 0.1.1
vslilypond lhl 1.7.3
zotero mbl 0.1.11
git-graph mhu 1.30.0
azure-dev ms- 0.8.0
vscode-azureappservice ms- 0.25.1
vscode-azurecontainerapps ms- 0.6.1
vscode-azurefunctions ms- 1.13.1
vscode-azureresourcegroups ms- 0.8.3
vscode-azurestaticwebapps ms- 0.12.2
vscode-azurestorage ms- 0.15.3
vscode-azurevirtualmachines ms- 0.6.5
vscode-cosmosdb ms- 0.20.0
vscode-docker ms- 1.28.0
vscode-edge-devtools ms- 2.1.3
black-formatter ms- 2023.7.13471009
flake8 ms- 2023.10.0
isort ms- 2023.11.13191009
python ms- 2023.23.13541005
vscode-pylance ms- 2023.12.101
jupyter ms- 2024.1.2023122501
jupyter-keymap ms- 1.1.2
jupyter-renderers ms- 1.0.17
vscode-jupyter-cell-tags ms- 0.1.8
vscode-jupyter-slideshow ms- 0.1.5
remote-containers ms- 0.329.0
remote-ssh ms- 0.108.2023122115
remote-ssh-edit ms- 0.86.0
remote-wsl ms- 0.81.8
vscode-remote-extensionpack ms- 0.25.0
azure-account ms- 0.11.6
azure-repos ms- 0.38.0
cmake-tools ms- 1.16.32
cpptools ms- 1.19.1
cpptools-extension-pack ms- 1.3.0
js-debug-nightly ms- 2023.12.1817
powershell ms- 2023.11.1
remote-explorer ms- 0.5.2023121309
remote-repositories ms- 0.40.0
remote-server ms- 1.6.2023121909
vscode-github-issue-notebooks ms- 0.0.130
vscode-node-azure-pack ms- 1.2.0
vscode-selfhost-test-provider ms- 0.3.22
vscode-serial-monitor ms- 0.11.0
vscode-speech ms- 0.3.2023110115
vsliveshare ms- 1.0.5900
windows-ai-studio ms- 0.2.1
autodocstring njp 0.6.1
pandocciter not 0.10.3
shiny-python Pos 0.1.5
shinyuieditor pos 0.5.0
quarto qua 1.109.0
r-debugger RDe 0.5.4
java red 1.25.1
vscode-xml red 0.26.1
vscode-yaml red 1.14.0
r REd 2.8.2
multi-command ryu 1.6.0
AudioQ Seh 0.0.2
vscode-deepl soe 1.0.10
abc-music sof 0.4.0
lua sum 3.7.3
latex-utilities tec 0.4.10
cmake twx 0.0.17
vscode-terminal-here Tyr 0.2.4
windows-terminal Tyr 0.7.0
errorlens use 3.16.0
intellicode-api-usage-examples Vis 0.2.8
vscodeintellicode Vis 1.2.30
vscode-arduino vsc 0.6.230727001
vscode-java-debug vsc 0.55.0
vscode-java-dependency vsc 0.23.3
vscode-java-pack vsc 0.25.15
vscode-java-test vsc 0.40.1
vscode-maven vsc 0.43.0
markdown-all-in-one yzh 3.5.1
grammarly znc 0.25.0

(1 theme extensions excluded)

A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vstes627:30244334
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
py29gd2263:30784851
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
a9j8j154:30646983
showlangstatbar:30737417
fixshowwlkth:30771523
showindicator:30805243
pythongtdpath:30726887
i26e3531:30792625
welcomedialog:30812478
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
pythonmpswarning:30901777
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30926734
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
aa_t_chat:30882232
cp7184t:30925682

@meganrogge
Copy link
Contributor

Thank you for the issue JooYoung. I cannot access the gif because it seems to be a private link.

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Jan 3, 2024
@meganrogge meganrogge added this to the December / January 2024 milestone Jan 3, 2024
meganrogge added a commit that referenced this issue Jan 4, 2024
jrieken added a commit that referenced this issue Jan 10, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 10, 2024
@roblourens roblourens added the verified Verification succeeded label Jan 25, 2024
@aiday-mar aiday-mar added this to the December / January 2024 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
6 participants