Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polish editor group context keys in WorkbenchContextKeysHandler #213334

Closed
benibenj opened this issue May 23, 2024 · 0 comments · Fixed by #219669
Closed

Polish editor group context keys in WorkbenchContextKeysHandler #213334

benibenj opened this issue May 23, 2024 · 0 comments · Fixed by #219669
Assignees
@benibenj
Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue workbench-editors Managing of editor widgets in workbench window
Milestone
July 2024

Comments

@benibenj
Copy link
Contributor

Check all context keys in WorkbenchContextKeysHandler related to editors and groups. Make sure none are missing. Make sure context keys are only changed when really needed (don't listen to too many events if not needed)
@benibenj benibenj added the polish Cleanup and polish issue label May 23, 2024
@benibenj benibenj self-assigned this May 23, 2024
This was referenced May 23, 2024
Merged
Closed
@bpasero bpasero added this to the May 2024 milestone May 24, 2024
@bpasero bpasero added the workbench-editors Managing of editor widgets in workbench window label May 24, 2024
@benibenj benibenj modified the milestones: May 2024, June 2024 May 26, 2024
@benibenj benibenj modified the milestones: June 2024, July 2024 Jun 25, 2024
@benibenj benibenj mentioned this issue Jul 2, 2024
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 2, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 3, 2024
aaronchucarroll pushed a commit to aaronchucarroll/vscode that referenced this issue Jul 10, 2024
@benibenj @aaronchucarroll
fixes microsoft#213334 (microsoft#219669)
576e41a 
fixes 213334
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benibenj benibenj

Labels
insiders-released Patch has been released in VS Code Insiders polish Cleanup and polish issue workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Milestone
July 2024
Development

Successfully merging a pull request may close this issue.

fixes #213334 microsoft/vscode
3 participants
@bpasero @benibenj @vscodenpa