Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChatWidget#onDidChangeContentHeight doesn't fire when attaching context #221385

Closed
jrieken opened this issue Jul 10, 2024 · 0 comments · Fixed by #221486
Closed

ChatWidget#onDidChangeContentHeight doesn't fire when attaching context #221385

jrieken opened this issue Jul 10, 2024 · 0 comments · Fixed by #221486
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jul 10, 2024

In process of enabling file attachments for inline chat. It seems that adding context doesn't trigger a onDidChangeContentHeight-event which causes ugly layouting for the content chat widget. Tho, it does call re-layout which is fishy because it doesn't give the owner a chance to assign a new height

jrieken added a commit that referenced this issue Jul 11, 2024
…d with, should have a width defined

fyi @joyceerhl this changes things around attached context and its event, also works around #221385

microsoft/vscode-copilot#6622
jrieken added a commit that referenced this issue Jul 11, 2024
* Show attach context action depending on the `chat.experimental.variables.XYZ` setting

re microsoft/vscode-copilot#6622

* set `supportsFileReferences`-flag based on `chat.experimental.variables.XYZ` setting

* inline chat content widget should not hide when it has been interacted with, should have a width defined

fyi @joyceerhl this changes things around attached context and its event, also works around #221385

microsoft/vscode-copilot#6622

* hide #selection and #editor when in editor inline chat

the implementation is quite ugly and needs some debt removal, for now the names and location are hardcoded
@joyceerhl joyceerhl added the bug Issue identified by VS Code Team member as probable bug label Jul 11, 2024
@joyceerhl joyceerhl added this to the July 2024 milestone Jul 11, 2024
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 11, 2024
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 24, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants