-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debugger Hover #221503
Comments
Two of my employees are facing the same issue. |
Facing similar issue. |
Facing the same problem... just lost hours of work investigating a non-issue! |
What language are you debugging? |
Typescript |
Same. |
Please share a code snippet where you see this happening, and let me know where you're hovering that's incorrectly showing as undefined. Thanks! |
Logs would also be handy in addition to that if you're able to grab them: /jsDebugLogs |
Please collect trace logs using the following instructions:
|
@ashishpat @yc5x Can either of you provide the above in regards to the hover debugging not working? Thanks. |
When hovering over GUID, it shows undefined, while the local variable and debug console both show the correct value. |
Same problem: Typescript, vscode 1.91.1, OS Windows |
Could one of you share your tsconfig as well? |
|
I haven't been quite able to reproduce this, but this is the explaination I see for microsoft/vscode#221503, plausibly caused by sourcemap funkiness. The root cause is that a hover evaluation's scope is being misidentified as happening in a scope above the one it should actually run in. We then saw this and thought we should hoist a variable, but don't find a variable to hoist, and leave the replaced identifier in the expression. If the scope were not misidentified, then the behavior would have been identical because the variable would not be defined anyway. In this PR we replace the identifier back to its original if we don't find a variable to hoist, and also add logging to help any future issues.
Thanks, I have trouble reproducing this but I put in a fix for what I believe to be the cause. I would appreciate you trying it out by doing the following:
Or, wait for the normal nightly build in about 25 hours |
I haven't been quite able to reproduce this, but this is the explaination I see for microsoft/vscode#221503, plausibly caused by sourcemap funkiness. The root cause is that a hover evaluation's scope is being misidentified as happening in a scope above the one it should actually run in. We then saw this and thought we should hoist a variable, but don't find a variable to hoist, and leave the replaced identifier in the expression. If the scope were not misidentified, then the behavior would have been identical because the variable would not be defined anyway. In this PR we replace the identifier back to its original if we don't find a variable to hoist, and also add logging to help any future issues.
Yes, that works. Thanks. |
Type: Bug
When ever I use the debuger to hoover over variables to see the value it says undefiend most of the time even though is not, I can see the value on the top left "Variable" window, but it takes away the amazing feature you have that I can just hoover pleasee fix it!!!
VS Code version: Code 1.91.1 (f1e16e1, 2024-07-09T22:06:49.809Z)
OS version: Windows_NT x64 10.0.22631
Modes:
System Info
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Extensions (43)
A/B Experiments
The text was updated successfully, but these errors were encountered: