Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Const enums aren't inlined anymore #227372

Closed
jrieken opened this issue Sep 2, 2024 · 1 comment · Fixed by #227380
Closed

Const enums aren't inlined anymore #227372

jrieken opened this issue Sep 2, 2024 · 1 comment · Fixed by #227380
Assignees
@bpasero @jrieken
Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Milestone
September 2024

Comments

@jrieken
Copy link
Member

jrieken commented Sep 2, 2024 •
edited
Loading

For some reasons we have lost the inlining of const enum. We should restore that because we have promised ourself perf gains from it (reading a value vs properties accesses)
@jrieken jrieken added engineering VS Code - Build / issue tracking / etc. ESM Issues caused by our AMD => ESM work labels Sep 2, 2024
@jrieken jrieken added this to the September 2024 milestone Sep 2, 2024
@jrieken
Copy link
Member Author

jrieken commented Sep 2, 2024

looks like a regression from a9e0dbd

@jrieken jrieken removed the ESM Issues caused by our AMD => ESM work label Sep 2, 2024
jrieken added a commit that referenced this issue Sep 2, 2024
@jrieken
disable isolatedModules because they prevent const enum inlining
575d93c 
fixes #227372
This was referenced Sep 2, 2024
Merged
Closed
@jrieken jrieken closed this as completed in 2456c4b Sep 2, 2024
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Sep 2, 2024
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 5, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@jrieken jrieken

Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
September 2024
Development

Successfully merging a pull request may close this issue.

disable isolatedModules because they prevent const enum inlining microsoft/vscode
2 participants
@bpasero @jrieken