Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy search doing a bad job of prioritizing search results #35572

Closed
PaddyMann opened this issue Oct 4, 2017 · 7 comments
Closed

Fuzzy search doing a bad job of prioritizing search results #35572

PaddyMann opened this issue Oct 4, 2017 · 7 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster quick-pick Quick-pick widget issues
Milestone

Comments

@PaddyMann
Copy link

  • VSCode Version: Code 1.16.1 (27492b6, 2017-09-14T16:24:39.530Z)
  • OS Version: Darwin x64 16.6.0
  • Extensions:
Extension Author (truncated) Version
vscode-eslint dba 1.3.2
prettier-vscode esb 0.24.0
atom-keybindings ms- 3.0.2
vscode-todo-highlight way 0.5.11

(1 theme extensions excluded)


Steps to Reproduce:

If you've got a large code base, the fuzzy search picks up too much noise and doesn't prioritize the sensible results.

For example, I have a file settings.html that's in a directory called participants. So I search for parti settings.

Here's what VSCode shows:
image

vs. Atom (with the file I'm after listed second):
image

This seems to have been an issue for a long time, but related issues have been closed without fixing it. e.g. #968

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the search Search widget and operation issues label Oct 4, 2017
@roblourens roblourens assigned jrieken and unassigned roblourens Oct 4, 2017
@roblourens roblourens removed the search Search widget and operation issues label Oct 4, 2017
@jrieken jrieken assigned bpasero and unassigned jrieken Oct 5, 2017
@bpasero
Copy link
Member

bpasero commented Oct 5, 2017

@PaddyMann did some tweaks in this area this week, can you either let me know if I could access the same sources (if open source) or give this insider build a try on it: https://az764295.vo.msecnd.net/insider/2e2613f7739c31832496f617356f5fb8eadc2ca1/VSCode-darwin-insider-unsigned.zip

@bpasero bpasero added quick-pick Quick-pick widget issues workbench info-needed Issue requires more information from poster labels Oct 5, 2017
@bpasero bpasero added this to the Backlog milestone Oct 5, 2017
@PaddyMann
Copy link
Author

You legend @bpasero - that works a treat 😄

image

I'm not familiar with your release cycles - when will this drop into a full release?

@bpasero
Copy link
Member

bpasero commented Oct 5, 2017

@PaddyMann unfortunately another month because we just wrapped up our 1.17 release. But you can stay on our insider releases, they are typically quite stable.

Marking as duplicate of #34210

@bpasero bpasero closed this as completed Oct 5, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 5, 2017
@bpasero bpasero modified the milestones: Backlog, October 2017 Oct 5, 2017
@fluffynuts
Copy link

This is a great improvement over the existing search! Would it be possible to have some way to make this search box wider? I have a rather deep solution, such that file searches, which are making far better hits now, are still not obvious until I mouse over each entry in the list to get the full text. At the moment. this search box only takes up like 1/4 of the width of my screen -- I have plenty of screen real estate which could make this easier to read, if I could just resize the box...

@sluongng
Copy link

I have not follow discussions about this for long but have you guys considered giving user the option to choose their own search implementation?

For example I want to use https://github.com/junegunn/fzf/ or https://github.com/lotabout/skim.

I wish to have configurable search options, similar to configurable run/debug settings. There I can link the search call to my own binary(ies) with parameters to further customize the search.

bpasero added a commit that referenced this issue Oct 23, 2017
@grothkopp
Copy link

grothkopp commented Oct 25, 2017

bildschirmfoto 2017-10-25 um 12 02 21

@bpasero I downloaded your insider build, but my results were not as great. As you can see in the screenshot I have a directory named "lioshop" but the files in there are only listed on position 11 & 12 and not even all of them.

Here are some suggestions to improve the matching:

  • make it "greedy". In the screenshot of @PaddyMann settings should match settings in settings.js and not setting + the s in the extension.

  • make a priorisation like:

  1. longest match in file or path ("lioshop")

  2. matching uppercase characters or first character in files (No one would probably search for ListOffersHistoryResponse by entering "lioshop", but "lohr" or "listhr")

@bpasero
Copy link
Member

bpasero commented Oct 25, 2017

@grothkopp this is a consequence of us always treating a match in the file name higher than anything else. There is still #25925 opened to cover that case.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster quick-pick Quick-pick widget issues
Projects
None yet
Development

No branches or pull requests

7 participants