-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fuzzy search doing a bad job of prioritizing search results #35572
Comments
@PaddyMann did some tweaks in this area this week, can you either let me know if I could access the same sources (if open source) or give this insider build a try on it: https://az764295.vo.msecnd.net/insider/2e2613f7739c31832496f617356f5fb8eadc2ca1/VSCode-darwin-insider-unsigned.zip |
You legend @bpasero - that works a treat 😄 I'm not familiar with your release cycles - when will this drop into a full release? |
@PaddyMann unfortunately another month because we just wrapped up our 1.17 release. But you can stay on our insider releases, they are typically quite stable. Marking as duplicate of #34210 |
This is a great improvement over the existing search! Would it be possible to have some way to make this search box wider? I have a rather deep solution, such that file searches, which are making far better hits now, are still not obvious until I mouse over each entry in the list to get the full text. At the moment. this search box only takes up like 1/4 of the width of my screen -- I have plenty of screen real estate which could make this easier to read, if I could just resize the box... |
I have not follow discussions about this for long but have you guys considered giving user the option to choose their own search implementation? For example I want to use https://github.com/junegunn/fzf/ or https://github.com/lotabout/skim. I wish to have configurable search options, similar to configurable run/debug settings. There I can link the search call to my own binary(ies) with parameters to further customize the search. |
@bpasero I downloaded your insider build, but my results were not as great.
As you can see in the screenshot I have a directory named "lioshop" but the files in there are only listed on position 11 & 12 and not even all of them.
Here are some suggestions to improve the matching:
|
@grothkopp this is a consequence of us always treating a match in the file name higher than anything else. There is still #25925 opened to cover that case. |
(1 theme extensions excluded)
Steps to Reproduce:
If you've got a large code base, the fuzzy search picks up too much noise and doesn't prioritize the sensible results.
For example, I have a file
settings.html
that's in a directory calledparticipants
. So I search forparti settings
.Here's what VSCode shows:
vs. Atom (with the file I'm after listed second):
This seems to have been an issue for a long time, but related issues have been closed without fixing it. e.g. #968
Reproduces without extensions: Yes
The text was updated successfully, but these errors were encountered: