Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to .gitattributes #45052

Closed
4 tasks done
joaomoreno opened this issue Mar 5, 2018 · 1 comment
Closed
4 tasks done

Move to .gitattributes #45052

joaomoreno opened this issue Mar 5, 2018 · 1 comment
Assignees
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Mar 5, 2018

Many thanks to @sharwell for originally pushing for this in #28945

@joaomoreno joaomoreno added debt Code quality issues engineering VS Code - Build / issue tracking / etc. labels Mar 5, 2018
@joaomoreno joaomoreno added this to the March 2018 milestone Mar 5, 2018
@joaomoreno joaomoreno self-assigned this Mar 5, 2018
@joaomoreno
Copy link
Member Author

joaomoreno commented Mar 7, 2018

@Microsoft/vscode

I have introduced a .gitattributes file. This means we no longer have to (or even should) configure the autocrlf and safecrlf git settings. We used to recommend Windows users to use core.autocrlf=false and core.safecrlf=true. You can now remove those customisations.

What should I do?

Regardless of your platform, you should pull and re-checkout the entire vscode repository. First, make sure you have a clean working directory: no changes! Then:

git pull
git rm --cached -r .
git reset --hard

@rebornix rebornix added the verified Verification succeeded label Mar 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc. verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants