Typescript Find All References stopped finding references 1.30.0

[mdenson-dayspring]

Issue Type: Bug

This is an awesome feature that I used extensively when it was the preview List All References.

With the latest release it stopped finding references with TS. I am able to command click from a reference to the definition (cool) but the Find all References doesn't list the use I just came from

VS Code version: Code 1.30.0 (c6e592b, 2018-12-11T22:22:15.793Z)
OS version: Darwin x64 18.2.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-8259U CPU @ 2.30GHz (8 x 2300)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (0.14GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (1)

Extension	Author (truncated)	Version
EditorConfig	Edi	0.12.5

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Opening files from find all references panel is broken (#60165)
• TS reference code lens should be able to open reference list (#64376)
• Allow "Find All References" to expand to a full tab (#12101)
• Suggestions for improving the "Find All References" window (#31720)
• Rename Find All References to Peek References (#62772)

[mdenson-dayspring]

Ah! Is this dependent on some parsing process running in the background?

It has started working now after a few minutes. Maybe an indication that the feature may work after the project is processed, with an indication of progress (maybe).

Thanks for the great tool.

[mjbvz]

Was there an Initializing JS/TS language features... spinner shown in the status bar when it did not work? Also, does your project have a tsconfig.json and are both files part of it?

[mdenson-dayspring]

Hi I did not see the spinner. I did specifically look to see if something was going on in the background.

Yes I do have a tsconfig.json. Multiple actually. The project is an angular project with multiple (2) apps and several libraries. Each app/lib has a tsconfig.json.

FYI we are using the ng tooling extension by nrwl called nx.

[mjbvz]

Do you have an example project that you can share or can you describe the project layout (along with contents of the tsconfigs)

[dcecile]

I'm also seeing this with a multiple tsconfig.json setup. (Even though technically all of them should be "joined" via a root tsconfig.json that uses project references.)

Here's a minimal repro of my setup: https://github.com/dcecile/typescript-references-test

common/
  message.ts
  tsconfig.json
server/
  hello.ts
  tsconfig.json
client/
  sharedMain.ts
  tsconfig.json

• Both client and server reference the common project
• "Find references" fails to find the references to the common function
• "Rename symbol" also fails to rename the references
• After loading files from the client and server projects, find references works

[enzy]

I'm facing this issue in an Angular 7 project after the recent VS code update, it did work in the previous version though.

[exthost] [error] TypeError: Cannot read property 'replace' of undefined
	at Function.file (resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:99:632)
	at getIconPath (resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:423:936)
	at getLightIconPath (resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:423:728)
	at g.createTreeItem (resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:422:618)
	at g.createTreeNode (resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:422:508)
	at g.createAndRegisterTreeNode (resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:422:299)
	at define.fetchChildrenNodes.a.asPromise.then.Promise.all.u.coalesce.map.a.asPromise.then.r (resources\app\out\vs\workbench\services\extensions\node\extensionHostProcess.js:421:169)

Version: 1.32.0-insider (user setup)
Commit: 7ff2398cfd0776409ff687ce811f1d7ff3375dc8
Date: 2019-02-11T11:42:54.142Z
Electron: 3.1.3
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.18334

[qlqllu]

I have the similar issue, and I narrow down the issue to: only the export function fn1() can't find its references, the functions in a class can find their references.

BTW, rename symbol on the function that can't find its references will report an error, but I can't find a way to copy the error stack.

My vscode version is 1.31.1, on windows 10. The same vscode version on mac does not have this issue.

[qlqllu]

The find all references starts working after some operations (I don't which operation make this function work). I am sure waiting for sometime can't make this work.

[mjbvz]

@qlqllu @enzy @dcecile Please open new issues.

@mdenson-dayspring If you are still seeing this issue in the latest VS Code insider, let me know. Please include more information about your project contents and structure

[achimschrepfer]

@mjbvz the issue (not finding all references of a given symbol throughout the whole workspace) seems to happen on projects with multiple tsconfig.json files. I have an Angular NX Workspace with several libraries in it. Navigation features like find all references, lint messages and errors and warnings never seem to be collected througout the whole workspace.

In simple TS projects I never experience those issues.

[qlqllu]

Yes, my project has multiple tsconfig.json and I have this issue. 发自我的华为手机

…

-------- 原始邮件 -------- 主题：Re: [Microsoft/vscode] Typescript Find All References stopped finding references 1.30.0 (#65102) 发件人：Achim Schrepfer 收件人：Microsoft/vscode 抄送：Junshan Liu ,Mention @mjbvz<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mjbvz&d=DwMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=3AW-ICN55TL8tz2SMsXuf53e6BdEmEOpKpNyTjPFNhQ&m=xs71kYW-ivkk8v3i6PpEAaBgObOGxmKSrWSUlAIzr24&s=FRXSjhdz923p-8ahtamN5i5qFefIsWaDod4FwI86P74&e=> the issue (not finding all references of a given symbol throughout the whole workspace) seems to happen on projects with multiple tsconfig.json files. I have an Angular NX Workspace with several libraries in it. Navigation features like find all references, lint messages and errors and warnings never seem to be collected througout the whole workspace. In simple TS projects I never experience those issues. ― You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Microsoft_vscode_issues_65102-23issuecomment-2D471186112&d=DwMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=3AW-ICN55TL8tz2SMsXuf53e6BdEmEOpKpNyTjPFNhQ&m=xs71kYW-ivkk8v3i6PpEAaBgObOGxmKSrWSUlAIzr24&s=YabSwiIQmCUpxThoSW5XJ-GI2z6gudMiFdUyB2I0Uis&e=>, or mute the thread<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AA-2DAAHn9jXW0ZVCPLr0c9fBhUd5V2R-5F5ks5vU8ukgaJpZM4ZUBgy&d=DwMFaQ&c=n6-cguzQvX_tUIrZOS_4Og&r=3AW-ICN55TL8tz2SMsXuf53e6BdEmEOpKpNyTjPFNhQ&m=xs71kYW-ivkk8v3i6PpEAaBgObOGxmKSrWSUlAIzr24&s=KkU7caT0bZ5_0fyhhq1S02inOrb8X_lx7K5ksKIu9bo&e=>.

[dcecile]

@achimschrepfer @qlqllu I created #69001 hoping to track this multiple tsconfig.json issue