Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal cursor style changes on blink #77559

Closed
ghost opened this issue Jul 18, 2019 · 5 comments
Closed

Terminal cursor style changes on blink #77559

ghost opened this issue Jul 18, 2019 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@ghost
Copy link

ghost commented Jul 18, 2019

  • VSCode Version: 1.36.1
  • OS Version: macOS 10.14.3

Steps to Reproduce:

  1. Open internal terminal
  2. In settings set cursor style for terminal to line
  3. Enable cursor blinking
  4. Check the cursor blinking

Info: Cursor changes style to block on every blink.
cursor

Does this issue occur when all extensions are disabled?: Yes

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Jul 27, 2019
@Tyriar Tyriar added this to the Backlog milestone Jul 27, 2019
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Jul 27, 2019
@skprabhanjan
Copy link
Contributor

@Tyriar , I cannot reproduce this issue.
The cursor blinking seems to be correct when I tried this.

@ghost
Copy link
Author

ghost commented Jul 29, 2019

@skprabhanjan I use zsh shell in integrated terminal, but this shoudn't be the case. Same shell works fine in normal Terminal app. When I switched shell to bash in integrated-terminal issue still occurs. It looks like when out of focus, integrated-terminal cursor ignores selected style and renders as block.

@Tyriar
Copy link
Member

Tyriar commented Jul 31, 2019

I can't repro either, it definitely seems to be happening though. @karolfalkiewicz have you set terminal.integrated.rendererType?

It looks like when out of focus, integrated-terminal cursor ignores selected style and renders as block.

#67410

@Tyriar Tyriar modified the milestones: Backlog, August 2019 Aug 10, 2019
@Tyriar Tyriar removed the help wanted Issues identified as good community contribution opportunities label Aug 10, 2019
@Tyriar Tyriar closed this as completed in 3ff362c Aug 12, 2019
@mjbvz mjbvz added the verified Verification succeeded label Aug 28, 2019
@ghost
Copy link
Author

ghost commented Aug 29, 2019

@Tyriar I checked once again. It happens only when Renderer Type is set up to dom. Canvas or auto works fine.

@Tyriar
Copy link
Member

Tyriar commented Sep 3, 2019

@karolfalkiewicz it's fixed in the upcoming version

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 26, 2019
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
Diff: xtermjs/xterm.js@30161c3...f3b9dc0

Changes:

- Fix cursor blink for non-block cursor in DOM renderer
- Remove applyAddon
- Re-enable buffer tests
- Fix dom -> canvas renderer not drawing viewport

Fixes microsoft#77559
Fixes microsoft#78882
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants