Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of trailing newlines needs to be staged in two parts #79910

Closed
jrial opened this issue Aug 27, 2019 · 2 comments
Closed

Removal of trailing newlines needs to be staged in two parts #79910

jrial opened this issue Aug 27, 2019 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
May 2020

Comments

@jrial
Copy link

jrial commented Aug 27, 2019 •
edited
Loading

  • VSCode Version: 1.37.1
  • OS Version: Linux x64 4.15.1-58-generic

Steps to Reproduce:

  1. Remove trailing newlines from a file under version control.
  2. Go to the Source Control view.
  3. Try to stage the removal of these newlines: right-click on the right-hand side and select "stage selected changes"
  4. Notice how there's still one removal that appears to have been left behind.
  5. Repeat step 3
  6. Now your removals have all been staged.

Expected behaviour: at step 3 the entire newline removal should be staged.

Demo video: https://youtu.be/KmlczMUMK9w

Does this issue occur when all extensions are disabled?: Yes
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug git GIT issues help wanted Issues identified as good community contribution opportunities labels Aug 30, 2019
@joaomoreno joaomoreno added this to the Backlog milestone Aug 30, 2019
utsavm9 added a commit to utsavm9/vscode that referenced this issue Aug 31, 2019
@utsavm9
Fixes microsoft#79910
d3e6270
@utsavm9 utsavm9 mentioned this issue Aug 31, 2019
Merged
@utsavm9
Copy link
Contributor

utsavm9 commented Oct 13, 2019

Is there anything I missed regarding this issue? Why is this still open? 😅

@jrial
Copy link
Author

jrial commented Oct 14, 2019 •
edited
Loading

@utsavm9 Nope, I can still reproduce this under VS Code v1.39.1

If you haven't checked the video I linked, check it out, it demonstrates the issue better than words can.

[EDIT] Ah, I see you fixed it, but it hasn't been merged in yet. Not sure what the policy is in this repo regarding closing tickets, but perhaps this one's still open since the fix hasn't hit production yet?

@joaomoreno joaomoreno modified the milestones: Backlog, May 2020 Jun 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2020
@rzhao271 rzhao271 added the verified Verification succeeded label Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
5 participants
@joaomoreno @jrial @rzhao271 @utsavm9 and others