Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal.integrataed.splitCwd inherited doesn't work correctly for unicode characters #83496

Closed
CrazyF-wind opened this issue Oct 29, 2019 · 14 comments · Fixed by #157377
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. verified Verification succeeded
Milestone

Comments

@CrazyF-wind
Copy link

when split terminal in chinese path,error!

@vscodebot
Copy link

vscodebot bot commented Oct 29, 2019

@CrazyF-wind
Copy link
Author

CrazyF-wind commented Oct 29, 2019

I think this is language's problem.English path is very well.

@Tyriar
Copy link
Member

Tyriar commented Oct 29, 2019

It looks like your report is missing some important information, See this wiki page for more info on how to report actionable terminal issues.

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Oct 29, 2019
@CrazyF-wind
Copy link
Author

CrazyF-wind commented Oct 30, 2019

Thanks for your reply!

This is my VS Code Info:
version: 1.39.2
submit: 6ab5985
Data Time: 2019-10-15T15:33:00.827Z
Electron: 4.2.10
Chrome: 69.0.3497.128
Node.js: 10.11.0
V8: 6.9.427.31-electron.0
OS: Darwin x64 19.0.0

And this is the gif:
ezgif com-video-to-gif

@Tyriar
Copy link
Member

Tyriar commented Oct 30, 2019

Thanks, you can probably workaround this with this setting:

"terminal.integrated.splitCwd": "initial"

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues and removed info-needed Issue requires more information from poster labels Oct 30, 2019
@Tyriar Tyriar added this to the Backlog milestone Oct 30, 2019
@Tyriar Tyriar changed the title split terminal error terminal.integrataed.splitCwd inherited doesn't work correctly for unicode characters Oct 30, 2019
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Oct 30, 2019
@CrazyF-wind
Copy link
Author

I has try this settings by your suggestion. And it really not error.Thanks!But this way to create a terminal is not my default way.When I create a new terminal.It go to its father's file path , not it is before. If has a way to realize my need?

ezgif com-video-to-gif (1)

@Tyriar
Copy link
Member

Tyriar commented Oct 31, 2019

Yeah that's what the setting does, you can't get what you're after until we fix this bug.

@CrazyF-wind
Copy link
Author

OK!I understand.Thank you!

@Tyriar Tyriar reopened this Nov 1, 2019
@Arnaud73
Copy link

I guess this is obvious, but the problem also occurs with European characters (at least french), and very likely with Arabic, Japanese, Indian, Korean characters as well.

I also switched to "terminal.integrated.splitCwd": "initial" in order to work around the problem.

@recmo
Copy link

recmo commented Jan 17, 2021

I had this issue with the project folder itself containing unicode (greek letters). To my surprise, the "terminal.integrated.splitCwd": "initial" hack still worked, the new terminal now sucesfully launches in the project folder.

@Tyriar
Copy link
Member

Tyriar commented Oct 25, 2021

Also happens when the cwd is set via runInTerminal #135432

@int19h
Copy link

int19h commented Oct 25, 2021

Note that in the latter case, it's not just the cwd that's affected - it's also all the command line arguments.

@Tyriar
Copy link
Member

Tyriar commented Oct 25, 2021

@int19h good point, this is probably an issue in debug land actually or related to encoding in the shell. Reopening it.

@Tyriar Tyriar added the terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. label May 23, 2022
pingren added a commit to pingren/vscode that referenced this issue Aug 6, 2022
@Tyriar Tyriar modified the milestones: Backlog, August 2022 Aug 8, 2022
@Tyriar
Copy link
Member

Tyriar commented Aug 8, 2022

To verifier: When testing make sure shell integration is off

@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 8, 2022
@rzhao271 rzhao271 added verified Verification succeeded and removed verified Verification succeeded labels Aug 24, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities insiders-released Patch has been released in VS Code Insiders terminal Integrated terminal issues terminal-process Problems launching processes, managing ptys, exiting, process leaks, etc. verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants