Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call Hierarchy view sometimes highlights inside the peek (if open) #86327

Closed
eamodio opened this issue Dec 4, 2019 · 2 comments
Closed

Call Hierarchy view sometimes highlights inside the peek (if open) #86327

eamodio opened this issue Dec 4, 2019 · 2 comments
Assignees
Labels
callhierarchy polish Cleanup and polish issue
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Dec 4, 2019

Issue Type: Bug

I haven't yet figured out the steps to get this to happen, but sometimes instead of highlighting in the main editor, the Call Hierarchy view highlights in the peek (assuming it is open).

Refs: #85924

VS Code version: Code - Insiders 1.41.0-insider (7f1975a, 2019-12-04T10:20:42.228Z)
OS version: Windows_NT x64 10.0.19033

System Info
Item Value
CPUs Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.93GB (17.91GB free)
Process Argv
Screen Reader no
VM 0%
@eamodio
Copy link
Contributor Author

eamodio commented Dec 4, 2019

So it looks like this might be expected behavior (though a bit odd?). So it only happens when focus is inside the peek.

@jrieken
Copy link
Member

jrieken commented Dec 5, 2019

Yeah - it always (and only) shows highlights in the active editor and peek'ed editors are equal in that respect. I don't wanna go down the route of showing it in all visible editors but we can try only showing it in "real" editors. Tho that would mean highlight hide when peeking at something.

@jrieken jrieken added callhierarchy polish Cleanup and polish issue labels Dec 5, 2019
@jrieken jrieken added this to the December 2019 milestone Dec 5, 2019
jrieken added a commit to microsoft/vscode-references-view that referenced this issue Dec 10, 2019
jrieken added a commit that referenced this issue Dec 10, 2019
@jrieken jrieken closed this as completed Dec 10, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
callhierarchy polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

2 participants