Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text save participants are overwritten for each extension host #90359

Closed
bpasero opened this issue Feb 10, 2020 · 4 comments
Closed

Text save participants are overwritten for each extension host #90359

bpasero opened this issue Feb 10, 2020 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-io File I/O important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Feb 10, 2020

Only on Windows I see this test failing and as such have pushed a skip() for just that:

  1) workspace-namespace eol, change via onWillSave:

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert.ok(called)

      + expected - actual

      -false
      +true

      at extensions\vscode-api-tests\src\singlefolder-tests\workspace.test.ts:242:13
      at processTicksAndRejections (internal/process/task_queues.js:89:5)
@jrieken jrieken added this to the February 2020 milestone Feb 10, 2020
@jrieken jrieken added the engineering VS Code - Build / issue tracking / etc. label Feb 10, 2020
@bpasero
Copy link
Member Author

bpasero commented Feb 11, 2020

Actually seeing this on Linux too, I have pushed a change to disable it when running from web.

bpasero added a commit that referenced this issue Feb 11, 2020
jrieken added a commit that referenced this issue Feb 13, 2020
@jrieken
Copy link
Member

jrieken commented Feb 13, 2020

@bpasero add you for debugging help. This test works on playwright+macOS, in electron, and also when running from within web-selfhost. I see them failing on playwright+windows but the debugging is so limited that I don't know how to drill into it

@bpasero
Copy link
Member Author

bpasero commented Feb 13, 2020

@jrieken maybe with this sloMo option you could artificially slow down the test run to get a hold of the dev tools within? But I guess simple timeouts in the test would also help already.

@bpasero bpasero changed the title Web (Windows): workspace.test.ts: eol, change on willSave fails Text save participants are overwritten for each extension host Feb 14, 2020
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug file-io File I/O important Issue identified as high-priority and removed engineering VS Code - Build / issue tracking / etc. integration-test-failure labels Feb 14, 2020
@bpasero
Copy link
Member Author

bpasero commented Feb 14, 2020

Turns out that this is a race between the web worker extension host and the remote one and the text exposes it.

@roblourens roblourens added verified Verification succeeded and removed verified Verification succeeded labels Feb 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-io File I/O important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants