Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply debug console font size setting to input field #90714

Closed
janosh opened this issue Feb 14, 2020 · 5 comments · Fixed by #91261
Closed

Apply debug console font size setting to input field #90714

janosh opened this issue Feb 14, 2020 · 5 comments · Fixed by #91261
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@janosh
Copy link

janosh commented Feb 14, 2020

It's possible to adjust the debug console's font size via

"debug.console.fontSize": 12,

This currently does not affect the input field as is obvious when cranking up the size to 20. Since the input is part of the debug console, I think it should though.

large-font

@isidorn
Copy link
Contributor

isidorn commented Feb 17, 2020

I agree with you. debug.console.fontSize should also be aplied to the debug console input.
There might be some hard coded sizes that might not make this trivial to implement.

We are open to an elegant PR that fixes this

const debugConsole = this.configurationService.getValue<IDebugConfiguration>('debug').console;

In the meantime assigning this to backlog as we might tackle this in the future.
Thanks

@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities labels Feb 17, 2020
@isidorn isidorn added this to the Backlog milestone Feb 17, 2020
jeanp413 added a commit to jeanp413/vscode that referenced this issue Feb 24, 2020
@isidorn isidorn modified the milestones: Backlog, April 2020 Apr 7, 2020
@isidorn isidorn added the verification-needed Verification of issue is requested label Apr 7, 2020
@isidorn
Copy link
Contributor

isidorn commented Apr 7, 2020

To verify:

  1. Start debugging and hit a brekapoint
  2. Change debug.console.fontSize and make sure that the debug console input also respect the font size and that the input chevron looks good

@janosh
Copy link
Author

janosh commented Apr 8, 2020

Thanks for fixing this!

@isidorn
Copy link
Contributor

isidorn commented Apr 8, 2020

@janosh you should thank @jeanp413 he fixed it nicely via a PR

@janosh
Copy link
Author

janosh commented Apr 8, 2020

Gave him a thumbs up over at #91261 first but also wanted to thank you for the quick merge and review.

@jrieken jrieken added the verified Verification succeeded label Apr 28, 2020
@isidorn isidorn added the on-release-notes Issue/pull request mentioned in release notes label Apr 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities on-release-notes Issue/pull request mentioned in release notes verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants