Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make suggest widget resizable #109094

Merged
merged 19 commits into from
Oct 21, 2020
Merged

Make suggest widget resizable #109094

merged 19 commits into from
Oct 21, 2020

Conversation

jrieken
Copy link
Member

@jrieken jrieken commented Oct 21, 2020

This PR makes the suggest widget (list of completions and details) resizable

@jrieken
fix sash styling for monaco editor
2f15e9d
@jrieken
wip - resizable suggest widget
43e2e7d
@jrieken
towards details as overlay widget
b9c1779
@jrieken
add dom.Dimension#with more modification, adopt class-vs-interface usage
591c49a
@jrieken
add beforeRender and afterRender to IContentWidget
c748d1c
@jrieken
wip - resizable list and details
41ec71a
@jrieken
better presisting of sizes, simplify layout, fix issues with status bar
9521e6b
@jrieken
position tweak, persist size per editor type
3903ac3
@jrieken
"manually" place widget atop or below the cursor
2c23e0c
@jrieken
better resize/layout when showing atop
8ddcf56
@jrieken
place details at top or bottom of list
91e148c
@jrieken
only persist what has changed (width or height), not always the full …
f63ad10 
…new dimension
@jrieken
better guestimate for details size
3d92765
@jrieken
only show/layout details when wanted
daccca7
@jrieken
less flicker of details widget
7d8f2fa
@jrieken jrieken self-assigned this Oct 21, 2020
@jrieken jrieken merged commit 5046c97 into master Oct 21, 2020
@jrieken jrieken deleted the joh/resizeSuggest branch October 21, 2020 15:41
@jrieken jrieken added this to the October 2020 milestone Oct 21, 2020
@jrieken jrieken mentioned this pull request Oct 21, 2020
Closed
@Raydir
Copy link

Raydir commented Oct 22, 2020

resizing works for me. some sort of setting for "auto-size" could be interesting perhaps.
No bugs thus far ;)

@jrieken
Copy link
Member Author

jrieken commented Oct 22, 2020 •
edited
Loading

some sort of setting for "auto-size" could be interesting perhaps.

The list supports auto-size when double clicking the resize handles

@Raydir
Copy link

Raydir commented Oct 22, 2020 •
edited
Loading

@jrieken i ment the list with entries (width not height)

  • auto-size on "description" (detailinfo) works smoothly!

@alexkreidler alexkreidler mentioned this pull request Nov 18, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jrieken jrieken

Labels
None yet
Projects
None yet
Milestone
October 2020
Development

Successfully merging this pull request may close these issues.
2 participants
@jrieken @Raydir