-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update editor placeholder #146997
Update editor placeholder #146997
Conversation
Btw disregard the notification toast showing up, it will remove next. |
Lydia is out for the next few days but we can take a look |
Thanks! Merging in to get selfhost feedback early on, happy for more changes as a follow up as needed. I will also have to see how it looks like with multiple links appearing as actions. I assume we would want to go with links and not buttons right? |
Looks good! Links probably work better here given the longer strings used for actions. Feels a bit lighter compared to buttons as well. One nit: there's a bit of inconsistency between the action phrasing. One is a brief call to action ("Try again") and another is a question ("Do you want to open it anyway?"). Could shorten to "Open anyway"? |
Thanks, yeah I can change the wording. One thing to keep in mind is that I still have to somehow move the previous error toast into this place holder including text and actions. This will probably mean:
|
@bpasero would we be able to separate out the title + message? might help for readability, i know our toasts do not have titles so not sure what we can do here |
@misolori what we can always do is show the generic error message we had before and show the specifics as details, how would you style this in CSS? |
For #130971
@lychung7 @daviddossett maybe you could give me a 👍 / 👎 on the visuals, I tried to get close to the designs from Lydia.
The main knobs to adjust is these CSS rules, and I was guessing the
font-size
andgap
, so maybe you could just let me know if tweaks are needed.vscode/src/vs/workbench/browser/parts/editor/media/editorplaceholder.css
Lines 6 to 34 in 7a9dee2
//cc @misolori
The easiest to get one of these editors is to: